Emit map_migrated_tag_value in aws-wif placement output [murmur:back/bedrock-map-tagging] - #12
Open
chenruichou wants to merge 1 commit into
Open
Emit map_migrated_tag_value in aws-wif placement output [murmur:back/bedrock-map-tagging]#12chenruichou wants to merge 1 commit into
chenruichou wants to merge 1 commit into
Conversation
Add an optional map_migrated_tag_value variable that, when non-empty, appears in the placement output's aws block. The Go provisioner reads this field and stamps map-migrated=<value> on every EC2 resource the placement creates (instances, EBS volumes, ENIs, AMIs, snapshots). Empty by default — customer-owned accounts must never carry Prasso's MAP contract ID. Callers that own the account (the dog-food placement) set the value explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This change adds an optional AWS placement value that controls MAP cost-allocation tagging and can affect credits associated with EC2 spend. Because it may change financial outcomes when configured, it should receive human review. You can add or adjust custom eligibility rules. Learn more. |
zbigy
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
map_migrated_tag_valuevariable to theaws-wifmodule that, when non-empty, emits the value in the placement output'sawsblock asmap_migrated_tag_value. The Go provisioner in murmuration reads this field and stampsmap-migrated=<value>on every EC2 resource the placement creates.Why
The dog-food placements (
customer-prasso-tenant-vm-prod-awsaccount 684651436812, andnonprod-cstmr-plcmt-aws) are under Prasso's payer (231006511396) and their VMs should earn MAP credits. This field is the explicit own-account condition — set by whoever configures the placement, not derived fromplatform(which isfalsefor the dog-food accounts). Without it, the dog-food VMs go untagged because the provisioner only stamps the tag when the placement carries a non-empty value.Sequencing — this PR must merge FIRST
murmuration#6978 and back#15008 implement the rest of the MAP tagging. Both reference this module's new variable in TODO(MAP) comments. After this PR merges:
main.tfand nonprodnonprod-cstmr-plcmt.tf) to the resulting main-branch commitmap_migrated_tag_value = "mig2R6T017255"on both dog-food modulesBackward compatible
The variable defaults to
"". Existing callers that don't set it see no change — the placement output omits the field entirely.Created via Murmur
🤖 Generated with Claude Code