Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset names and citizen descriptions were interpolated into HTML, allowing stored markup to create elements in the dashboard, map popups, and citizen selector. Quoted asset names also broke the inline chart handler. API values now use DOM text APIs, and chart and repair controls use event listeners. Resolved reports are removed from the incident feed while preserving its latest-eight ordering.
The citizen form also had two competing submit handlers: a timer could announce success and clear the form before the API responded, and a successful upload permanently hid the modal. One async handler now waits for the API, prevents duplicate pending submissions, preserves input after failures, displays errors as text, and resets the form only after success. The modal can then reopen for another report.
Added reproducible Chromium tests, local test instructions, and GitHub Actions for browser and Python validation.
Validation:
Browser regression tests mock the API and map dependencies; they do not require a running database or external CDN.