Fix unreadable custom settings in Homebridge night mode - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebridge's night theme can leave Bootstrap's --bs-body-color set to dark text. The custom settings root used that variable, making labels and descriptions unreadable against the dark iframe background.
This change inherits the host text color and adds scoped night-theme colors for fields, placeholders, disabled values, help text, tables, buttons, and borders. It follows Homebridge's forwarded theme classes, including when the operating system uses the opposite appearance.
Browser regression checks load representative Bootstrap/Homebridge iframe styles after the plugin CSS, measure text and field-border contrast, switch between light/night themes, and check mobile width. CI results are pending at PR creation.
Configuration and device-control behavior are unchanged. This PR does not publish a release.