adding a build script for faiss-cpu package (faiss-wheel)#8436
Open
afsanjar wants to merge 19 commits into
Open
adding a build script for faiss-cpu package (faiss-wheel)#8436afsanjar wants to merge 19 commits into
afsanjar wants to merge 19 commits into
Conversation
An incorrect file was added
…ckpoint.sh cleanup
cdeepali
reviewed
Jul 21, 2026
|
|
||
|
|
||
| echo "Installing dependencies..." | ||
| curl -O https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm |
Contributor
There was a problem hiding this comment.
I don't think EPEL repos can be used here. So pls remove Lns 31-33.
The wrapper script builds python version not available on RH repo from source - here
cdeepali
reviewed
Jul 21, 2026
| dnf install -y epel-release-latest-9.noarch.rpm | ||
| dnf update -y | ||
| dnf install -y \ | ||
| python3.13 python3.13-devel python3.13-pip \ |
Contributor
There was a problem hiding this comment.
Suggested change
| python3.13 python3.13-devel python3.13-pip \ | |
| python3.12 python3.12-devel python3.12-pip \ |
cdeepali
reviewed
Jul 21, 2026
| openblas-devel make gcc g++ cmake git automake autoconf | ||
|
|
||
| echo "Upgrading Python tools..." | ||
| python3.13 -m pip install --upgrade setuptools wheel build uv |
Contributor
There was a problem hiding this comment.
Suggested change
| python3.13 -m pip install --upgrade setuptools wheel build uv | |
| python3 -m pip install --upgrade setuptools wheel build uv |
cdeepali
reviewed
Jul 21, 2026
| CP=$(python3.13 -c "import sysconfig; print(sysconfig.get_config_var('py_version_nodot'))") | ||
| uv build --wheel --config-setting wheel.py-api=cp$CP --extra-index-url $INDEX_URL_DEVPY | ||
|
|
||
| if ! (python3.13 -m pip install dist/faiss_cpu-$PACKAGE_VERSION-cp$CP-abi3-linux_ppc64le.whl ); then |
Contributor
There was a problem hiding this comment.
Suggested change
| if ! (python3.13 -m pip install dist/faiss_cpu-$PACKAGE_VERSION-cp$CP-abi3-linux_ppc64le.whl ); then | |
| if ! (python3 -m pip install dist/faiss_cpu-$PACKAGE_VERSION-cp$CP-abi3-linux_ppc64le.whl ); then |
cdeepali
reviewed
Jul 21, 2026
| echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | GitHub | Fail | Install_Fails" | ||
| fi | ||
| # Run tests | ||
| python3.13 -m pip install scipy==1.17.0 sentence-transformers --extra-index-url $INDEX_URL_DEVPY |
Contributor
There was a problem hiding this comment.
Suggested change
| python3.13 -m pip install scipy==1.17.0 sentence-transformers --extra-index-url $INDEX_URL_DEVPY | |
| python3 -m pip install scipy==1.17.0 sentence-transformers --extra-index-url $INDEX_URL_DEVPY |
cdeepali
reviewed
Jul 21, 2026
| echo "ERROR: test case not found" | ||
| exit 1 | ||
| fi | ||
| if ! (python3.13 $TEST_PATH); then |
Contributor
There was a problem hiding this comment.
Suggested change
| if ! (python3.13 $TEST_PATH); then | |
| if ! (python3 $TEST_PATH); then |
cdeepali
reviewed
Jul 21, 2026
|
|
||
| git clone --recursive ${PACKAGE_URL} | ||
| cd ${PACKAGE_DIR} | ||
| echo -e "\n[tool.uv]\nenvironments = [\"python_version == '3.13'\"]" >> pyproject.toml |
Contributor
There was a problem hiding this comment.
Is this package required only for Python 3.13?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?