Allow calling disconnect() on closed databases - #449
Merged
Conversation
simolus3
marked this pull request as draft
July 28, 2026 09:52
simolus3
force-pushed
the
allow-disconnect-on-closed-databases
branch
from
July 28, 2026 10:02
515257c to
427ab27
Compare
simolus3
marked this pull request as ready for review
July 28, 2026 10:02
Chriztiaan
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #441, we've started calling the
powersync_offline_sync_status()SQL function after disconnecting to fetch the updated sync status which is disconnected, but still contains current sync streams. That broke the ability to calldisconnect()on closed databases, which worked before.We disconnect in
close()and a closed database can't be connected, so doing nothing restores the old behavior.Closes #448