Reduce log severity from attachment queue service - #446
Merged
Conversation
simolus3
force-pushed
the
silence-attachment-logs
branch
from
July 29, 2026 09:42
c8a6a5a to
d461a42
Compare
Chriztiaan
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the syncing logic of the attachment system logs the same stuff multiple times and with a severity that is annoyingly high. This PR reduces visible logs:
fineand lower, meaning that they wouldn't get logged by default loggers.downloadAttachmentand friends log a message before they do anything, we don't need to log almost the same message before calling them.In other words, we only log when the attachment service actually does stuff (downloading, uploading, deleting). Its internal state can be observed with a logger set to level
fineand lower for debugging purposes, but this wouldn't happen by default.Closes #408.