Stage the plugin manifest in Prepare Release - #92
Merged
Conversation
prepare-release.ts has synced herdr-plugin.toml since the manifest was added, but the workflow commit never staged it, so release PRs would leave the plugin version behind.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal and directly corrects the staging list to include a release-critical file without altering workflow behavior otherwise.
Pull request overview
This PR fixes the Prepare Release GitHub Actions workflow so that it stages herdr-plugin.toml along with the other release version files, ensuring release PRs include the updated plugin manifest version.
Changes:
- Add
herdr-plugin.tomlto the workflow’sgit addlist in the “Create release PR” step.
File summaries
| File | Description |
|---|---|
.github/workflows/prepare-release.yml |
Stages herdr-plugin.toml so the release commit includes the manifest version bump produced by scripts/prepare-release.ts. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare-release.tshas syncedherdr-plugin.tomlas the fourth version file since Add Herdr plugin manifest and launcher #90, but the workflow'sgit addnever staged it — release PRs would ship with the plugin manifest version stuck at the previous releaseherdr-plugin.tomlto the staged files; no other workflow changesVerification
git addline now matches exactly the files written byscripts/prepare-release.ts(RELEASE_FILES: 3 package.json + herdr-plugin.toml + CHANGELOG.md rotation)