You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(cli): route output through vip.output and enable ruff T201 - #847
Root -q/--quiet and -v/--verbose set the vip.output level before any
subcommand runs. They use their own argparse dests so a subparser default
cannot clobber them; `vip verify --verbose` keeps meaning tracebacks and
now also enables debug output. `vip verify` exports VIP_VERBOSITY to the
pytest subprocess so the auth code in the plugin honours the level.
The CLI entry point now calls configure_logging() for every command
instead of only cleanup, so vip.* log records reach stderr uniformly and
cleanup._ensure_cli_logging is deleted. idp._verbose/_log_verbose are
folded into output.debug; start_headless_auth(verbose=True) raises the
level to verbose.
Each print becomes out (command results: report/bundle paths, install and
uninstall plans, status table, scaffold results, version, minted-key JSON),
info (progress and status), warn (warnings and prompts that need user
action), error (failures) or debug (mint cookie diagnostics). Streams
change deliberately: progress and warnings now go to stderr so stdout
carries only results. Message text is unchanged.
Interactive auth is unaffected by the stream move: pytest_configure output
is not captured on either stream (checked with a probe conftest), and
action-required prompts use warn so `vip -q` cannot hide them. Selftests
that read capsys .out for moved messages now read .err; negative
assertions check both streams.
These lines only print when minting fails, and they are the evidence for an XSRF or wrong-path failure, so hiding them behind -v forced users to rerun.
This PR centralizes VIP’s terminal output, separating command results from diagnostics and adding verbosity controls. It addresses #736 as part of the upkeep work in #831.
Changes:
Adds vip.output, root quiet/verbose flags, subprocess verbosity propagation, and a logging bridge.
Migrates output calls across CLI commands, authentication, installation, and product tests; progress and warnings now use stderr.
Enables Ruff T201 and updates selftests and documentation for the output contract.
File
Description
website/src/pages/guide.astro
Documents quiet mode and precedence.
src/vip/proxy.py
Routes proxy notices through info().
src/vip/plugin/results.py
Routes unproven-check warnings through warn().
src/vip/output.py
Adds output helpers, verbosity, and logging integration.
src/vip/install/runner.py
Separates plans from installation diagnostics.
src/vip/install/playwright.py
Routes installation progress to stderr.
src/vip/idp.py
Uses shared diagnostics and visible authentication prompts.
src/vip/cli/version.py
Routes version results through out().
src/vip/cli/verify.py
Propagates verbosity and migrates skip notices.
src/vip/cli/status.py
Routes status results through out().
src/vip/cli/scaffold.py
Separates scaffold results and warnings.
src/vip/cli/report.py
Separates report results, progress, and warnings.
src/vip/cli/install.py
Migrates install plans and cleanup warnings.
src/vip/cli/cleanup.py
Moves cleanup messages to shared output helpers.
src/vip/cli/bundle.py
Separates bundle results and warnings.
src/vip/cli/auth.py
Routes JSON results and errors through shared helpers.
src/vip/cli/app.py
Adds verbosity flags and initializes logging.
src/vip/auth/workbench.py
Migrates authentication progress, prompts, and warnings.
src/vip/auth/sso.py
Uses shared debug output.
src/vip/auth/scheme.py
Routes connection and TLS warnings to stderr.
src/vip/auth/flows.py
Migrates login output and headless verbosity handling.
start_headless_auth(verbose=True) no longer lifts a quiet level, and pytest_configure now attaches the vip logging handler so vip -v verify shows child-side debug logs.
Both Copilot findings are fixed in 7986440: -q now wins over --vip-verbose, and the pytest subprocess attaches the vip logging bridge so vip -v verify shows child-side logs.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Quiet mode still emits Locust diagnostics during verbose user-simulation runs because the diagnostic writer bypasses the resolved output verbosity.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Suppress Locust diagnostics when resolved output verbosity is QUIET
src/vip/cli/app.py:660
A user-simulation run such as vip -q verify --verbose --categories performance -- -n 0 still emits Locust diagnostics: --vip-verbose reaches run_user_simulation(), whose diagnostic writer bypasses vip.output. Make the vip_verbose fixture or the Locust diagnostic gate also check the resolved output verbosity, so QUIET suppresses these messages without changing --verbose's full-traceback behavior.
Fixed the Locust finding in 441ceef: the vip_verbose fixture is now False when the output level is quiet, so vip -q verify --verbose no longer prints the Locust request log or the load lines. Full tracebacks still follow --verbose.
Preview removed because the pull request was closed.
2026-11-19 22:00 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #736. Part of #831.
VIP used bare
print()as its output layer. This addssrc/vip/output.py, moves every call site onto it, and turns on ruffT201so new prints fail lint.out(): results (report path, plans, status, JSON)info(): progress-qwarn(),error()debug(): diagnostics-vvip -q/vip -v.vip verify --verbosestill means full tracebacks and also turns on debug;-qwins.VIP_VERBOSITYcarries the level into the pytest subprocess, so auth output honours it.vip.*logging goes through the same layer. It replaces cleanup's own handler and theidp._verboseflag.warn(), so-qcannot hide them.Behaviour change: warnings and progress, including all of
vip cleanup's counts, now go to stderr. Scripts that grep stdout for them need2>&1.