Skip to content

ci: route the last two copied CI blocks through the composites - #846

Merged
ian-flores merged 1 commit into
mainfrom
collapse-workflow-bash-643
Nov 19, 2026
Merged

ian-flores merged 1 commit into
mainfrom
collapse-workflow-bash-643

Conversation

@ian-flores

Copy link
Copy Markdown
Collaborator

Summary

#834 moved most of the copied workflow bash into composite actions. This PR moves the last two copies over:

  • connect-integration.yml now writes its job summary with write-smoke-summary. A new optional title input keeps its "🔗 Connect Integration Tests" heading. The three smoke workflows don't pass title and get the same heading as before.
  • mock-idp-e2e.yml's status job now uses check-smoke-status. A new optional resolvers input takes the extra connect-version job. The Mock-IdP E2E Status check name stays the same. The log lines now say "smoke scope" where they said "E2E scope".
  • mock-idp-e2e.yml lists check-smoke-status in its path filters.

Testing

  • actionlint is clean. zizmor reports 0 unpinned-uses and 0 artipacked.
  • Status rule: old inline bash vs. composite on all 512 result combinations. The exit code matched every time.
  • Summary: old block vs. composite on four JUnit cases. The output was byte-identical apart from the run date.
  • Mock-IdP E2E runs on this PR. Connect Integration runs via workflow_dispatch on this branch.

Closes #643

Copilot AI balanced review requested due to automatic review settings November 19, 2026 18:32
@ian-flores
ian-flores marked this pull request as ready for review November 19, 2026 18:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the CI deduplication changes.

No open issues 🎉

What changed in this PR

Completes the CI deduplication started in #834 by replacing the remaining copied summary and status-check blocks with shared composite actions.

Changes:

  • Routes Connect Integration summaries through write-smoke-summary, with an optional title that preserves its existing heading.
  • Routes Mock-IdP E2E status checks through check-smoke-status, adding support for extra version resolvers while preserving the check name.
  • Updates Mock-IdP path filters and documents the new action inputs and callers.
File Description
AGENTS.md Documents the expanded composite inputs and workflow usage.
.github/​workflows/​mock-idp-e2e.yml Uses the shared status action and includes it in path filters.
.github/​workflows/​connect-integration.yml Replaces the inline summary block with the shared action.
.github/​actions/​write-smoke-summary/​action.yml Adds an optional custom heading while retaining the default.
.github/​actions/​check-smoke-status/​action.yml Adds failure checks for optional extra version-resolver jobs.

Review effort: Balanced

@ian-flores
ian-flores merged commit ab9fbab into main Nov 19, 2026
41 checks passed
@ian-flores
ian-flores deleted the collapse-workflow-bash-643 branch November 19, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Collapse the duplicated workflow bash into composite actions

2 participants