Repository navigation
ci: route the last two copied CI blocks through the composites - #846
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the CI deduplication changes.
No open issues 🎉
What changed in this PR
Completes the CI deduplication started in #834 by replacing the remaining copied summary and status-check blocks with shared composite actions.
Changes:
- Routes Connect Integration summaries through
write-smoke-summary, with an optional title that preserves its existing heading. - Routes Mock-IdP E2E status checks through
check-smoke-status, adding support for extra version resolvers while preserving the check name. - Updates Mock-IdP path filters and documents the new action inputs and callers.
| File | Description |
|---|---|
AGENTS.md |
Documents the expanded composite inputs and workflow usage. |
.github/workflows/mock-idp-e2e.yml |
Uses the shared status action and includes it in path filters. |
.github/workflows/connect-integration.yml |
Replaces the inline summary block with the shared action. |
.github/actions/write-smoke-summary/action.yml |
Adds an optional custom heading while retaining the default. |
.github/actions/check-smoke-status/action.yml |
Adds failure checks for optional extra version-resolver jobs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#834 moved most of the copied workflow bash into composite actions. This PR moves the last two copies over:
connect-integration.ymlnow writes its job summary withwrite-smoke-summary. A new optionaltitleinput keeps its "🔗 Connect Integration Tests" heading. The three smoke workflows don't passtitleand get the same heading as before.mock-idp-e2e.yml's status job now usescheck-smoke-status. A new optionalresolversinput takes the extraconnect-versionjob. TheMock-IdP E2E Statuscheck name stays the same. The log lines now say "smoke scope" where they said "E2E scope".mock-idp-e2e.ymllistscheck-smoke-statusin its path filters.Testing
unpinned-usesand 0artipacked.workflow_dispatchon this branch.Closes #643