Repository navigation
revert(workbench): undo parallel smoke runs from #840 - #841
Merged
Merged
Conversation
…worker (…" This reverts commit 0c7e44d.
ian-flores
enabled auto-merge (squash)
November 18, 2026 23:37
Contributor
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Broken test grouping risks concurrent shared-account access, unsafe /tmp cleanup can delete existing checkouts and uncommitted work, and shortened login retries can fail before the sign-in throttle expires.
4 open issues
What changed in this PR
This PR reverts the parallel Workbench smoke-test setup, returning the CI suite to serial execution and removing supporting per-worker account changes from VIP’s test framework.
Changes:
- Run Workbench smoke tests with
-n 0and remove per-worker account provisioning. - Revert username isolation, clone paths, grouping behavior, and login retry timing; adjust selftests and documentation.
- Restore pytest 9.2.0 and remove its Dependabot upgrade restriction.
| File | Description |
|---|---|
uv.lock |
Updates the pytest resolution and lockfile revision. |
src/vip/plugin/selection.py |
Restores the general group fallback and removes early hook priority. |
src/vip_tests/workbench/test_git_ops.py |
Restores /tmp as the default clone parent. |
src/vip_tests/workbench/naming.py |
Removes per-worker username helpers. |
src/vip_tests/workbench/login.py |
Reduces the default retry delay to two seconds. |
src/vip_tests/workbench/conftest.py |
Removes per-worker username overrides and grouping opt-in. |
src/vip_tests/workbench/cleanup.py |
Uses the configured username for token-based cleanup. |
selftests/test_workbench_parallel.py |
Removes per-worker account, retry-delay, and xdist integration checks. |
selftests/test_workbench_git_ops.py |
Updates clone-path expectations and removes worker-isolation coverage. |
selftests/test_workbench_cleanup.py |
Removes the per-worker cleanup-account test. |
pyproject.toml |
Restores the pytest 9.2.0 dependency pin. |
AGENTS.md |
Removes guidance on per-worker accounts and xdist compatibility. |
.github/workflows/workbench-smoke.yml |
Disables parallel execution and removes worker-account provisioning. |
.github/dependabot.yml |
Removes the exclusion for pytest versions 9.2 and later. |
Review effort: Balanced
| "playwright==1.65.0", # exact-pinned: shapes vip run output; see docs/development.md | ||
| "pyotp~=2.9", | ||
| "pytest==9.1.1", # exact-pinned; at/above CVE-2025-71176 floor (9.0.3); <9.2 until pytest-xdist > 3.8.0 (pytest-dev/pytest-xdist#1407) | ||
| "pytest==9.2.0", # exact-pinned; at/above CVE-2025-71176 floor (9.0.3) |
|
|
||
|
|
||
| @pytest.hookimpl(tryfirst=True) | ||
| def pytest_collection_modifyitems( |
| readback_lang: str, | ||
| *, | ||
| workdir: str | None = None, | ||
| workdir: str = "/tmp", |
| workbench_auth_error: str | None = None, | ||
| max_retries: int = 3, | ||
| retry_delay: float = 6.0, | ||
| retry_delay: float = 2.0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reverts #840 (0c7e44d), which was merged before review finished.
It will come back in a new PR together with the remaining fix: under
--interactive-auth/--headless-auth, the sign-out scenario shares an xdist group with login, so it can run early and end the session other workers are using.