Skip to content

revert(workbench): undo parallel smoke runs from #840 - #841

Merged
ian-flores merged 1 commit into
mainfrom
revert-840-wb-smoke-parallel-644
Nov 18, 2026
Merged

ian-flores merged 1 commit into
mainfrom
revert-840-wb-smoke-parallel-644

Conversation

@ian-flores

@ian-flores ian-flores commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Reverts #840 (0c7e44d), which was merged before review finished.

It will come back in a new PR together with the remaining fix: under --interactive-auth / --headless-auth, the sign-out scenario shares an xdist group with login, so it can run early and end the session other workers are using.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 23:37
@ian-flores
ian-flores enabled auto-merge (squash) November 18, 2026 23:37
@ian-flores ian-flores changed the title Revert "ci(workbench): run the smoke suite in parallel, one user per … revert(workbench): undo parallel smoke runs from #840 Nov 18, 2026
@ian-flores
ian-flores merged commit 96d4f74 into main Nov 18, 2026
48 of 50 checks passed
@ian-flores
ian-flores deleted the revert-840-wb-smoke-parallel-644 branch November 18, 2026 23:44
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
Preview removed because the pull request was closed.
2026-11-18 23:44 UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Broken test grouping risks concurrent shared-account access, unsafe /tmp cleanup can delete existing checkouts and uncommitted work, and shortened login retries can fail before the sign-in throttle expires.

4 open issues
What changed in this PR

This PR reverts the parallel Workbench smoke-test setup, returning the CI suite to serial execution and removing supporting per-worker account changes from VIP’s test framework.

Changes:

  • Run Workbench smoke tests with -n 0 and remove per-worker account provisioning.
  • Revert username isolation, clone paths, grouping behavior, and login retry timing; adjust selftests and documentation.
  • Restore pytest 9.2.0 and remove its Dependabot upgrade restriction.
File Description
uv.lock Updates the pytest resolution and lockfile revision.
src/​vip/​plugin/​selection.py Restores the general group fallback and removes early hook priority.
src/​vip_tests/​workbench/​test_git_ops.py Restores /tmp as the default clone parent.
src/​vip_tests/​workbench/​naming.py Removes per-worker username helpers.
src/​vip_tests/​workbench/​login.py Reduces the default retry delay to two seconds.
src/​vip_tests/​workbench/​conftest.py Removes per-worker username overrides and grouping opt-in.
src/​vip_tests/​workbench/​cleanup.py Uses the configured username for token-based cleanup.
selftests/​test_workbench_parallel.py Removes per-worker account, retry-delay, and xdist integration checks.
selftests/​test_workbench_git_ops.py Updates clone-path expectations and removes worker-isolation coverage.
selftests/​test_workbench_cleanup.py Removes the per-worker cleanup-account test.
pyproject.toml Restores the pytest 9.2.0 dependency pin.
AGENTS.md Removes guidance on per-worker accounts and xdist compatibility.
.github/​workflows/​workbench-smoke.yml Disables parallel execution and removes worker-account provisioning.
.github/​dependabot.yml Removes the exclusion for pytest versions 9.2 and later.

Review effort: Balanced

Comment thread pyproject.toml
"playwright==1.65.0", # exact-pinned: shapes vip run output; see docs/development.md
"pyotp~=2.9",
"pytest==9.1.1", # exact-pinned; at/above CVE-2025-71176 floor (9.0.3); <9.2 until pytest-xdist > 3.8.0 (pytest-dev/pytest-xdist#1407)
"pytest==9.2.0", # exact-pinned; at/above CVE-2025-71176 floor (9.0.3)


@pytest.hookimpl(tryfirst=True)
def pytest_collection_modifyitems(
readback_lang: str,
*,
workdir: str | None = None,
workdir: str = "/tmp",
workbench_auth_error: str | None = None,
max_retries: int = 3,
retry_delay: float = 6.0,
retry_delay: float = 2.0,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants