Skip to content

Launcher Kubernetes Profiles need to be configurable from Site Spec #5

Open

Description

@ian-flores

Currently the Launcher Kubernetes Profiles are hardcoded to use all of the resource profiles under the wildcard header https://github.com/rstudio/ptd/blob/1fc957cb40a0ae34bb23b4e1a26a00864ae61ad5/team-operator/internal/controller/core/site_controller_workbench.go#L179-L190

This needs to change to support using multiple profiles. Currently not a pressing need but will come up with enterprise clients that want to specifically control access to resources.


Migrated from rstudio/ptd#2149

Activity

  1. added a commit that references this issue on Feb 26, 2026
  2. khusmann commented on Oct 2, 2026

    @khusmann

    A few notes for whoever picks this up, from looking at ordering in team-operator's renderers (context in #172):

    • There is no working workaround today. additionalConfigs for launcher.kubernetes.profiles.conf is silently overwritten by the generated [*] section (additionalConfigs for launcher.kubernetes.profiles.conf is silently overwritten by generated profiles #173), so Site admins cannot add group or user launcher profiles at all.
    • Section order matters once there is more than one group. Launcher profiles resolve by level ([*] < [@group] < [user]), and file order breaks ties within a level, with the later section winning. LauncherKubernetesProfiles is a map, so sections render alphabetically. A user in both @alpha and @zeta always gets @zeta's settings, and the admin cannot change that. This already applies to standalone Workbench resources with overlapping groups.
    • The fix belongs in the Workbench type, not just Site. The site controller passes profiles through the same LauncherKubernetesProfiles map that standalone Workbench uses. Adding a Site field that fills that map would give Site group profiles with the same alphabetical tie-break. An ordered form (for example, a list of sections) on Workbench fixes both. Since LauncherKubernetesProfiles is part of v1beta1, that probably means a new field next to the existing map, with the map deprecated.
    • Resource profile order may be worth a look in the same pass. launcher.kubernetes.resources.conf is deliberately sorted (default first, then by CPU and memory), but the resource-profiles list in the generated [*] is sorted alphabetically. I haven't checked which one the session launch dropdown follows.

    We're working through the same question for the Helm chart in rstudio/helm#944. Whatever shape we land on there could be mirrored here so the two stay consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions