Bump the artifact actions off Node.js 20 - #13
Merged
Conversation
GitHub Actions runners now force actions/upload-artifact@v4 and actions/download-artifact@v4 onto Node.js 24 and print a deprecation warning. Move to the current majors, which declare node24 themselves. upload v7 and download v8 are a pair: v7 adds unzipped direct uploads, and v8 is the version that handles them. v8 also turns an artifact digest mismatch from a warning into an error, which is the behavior we want here -- a corrupt dist/ must fail the job, not become a GitHub release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow's
publishandgithub-releasejobs print a deprecation warning:This moves both artifact actions to the current majors, which declare
node24themselves:actions/upload-artifact@v4->@v7actions/download-artifact@v4->@v8Notes
v6/ downloadv7. I went to the latest majors because they pair up: uploadv7adds unzipped direct uploads, and downloadv8is the version that handles them.v8also changes an artifact digest mismatch from a warning to an error. That is the behavior we want here -- a corruptdist/must fail the job instead of becoming a GitHub release.ubuntu-latest, so this is met.nameandpath, so no other change is needed.Testing
The release workflow runs on tag push only, so this cannot run on the PR. Verify on the next release that the warning is gone and that
dist/still reaches both PyPI and the GitHub release.