Repository navigation
Keep the weekly stats refresh in the sync PR, and push it without signing - #495
Open
jeroenjanssens wants to merge 1 commit into
Open
jeroenjanssens wants to merge 1 commit into
jeroenjanssens wants to merge 1 commit into
Conversation
…ning
- restore-pending-videos.sh also restores data/videos.toml from the open
sync PR (unless main changed it since). The scripts keep the stored view
counts on non-Monday nights, and the stored ones were main's, so
Tuesday's run undid Monday's refresh of 1,591 pages.
- create-pull-request: sign-commits false. Signing sends every changed file
in one API request, which timed out on 2 of the first 9 nights ("your
input was too large"); a git push has no such limit.
✅ Deploy Preview for posit-open-source canceled.
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite check
Related Issue
Follow-up to #486, based on the first nine nightly runs.
Description of changes
Two problems with the nightly video sync:
main, whose stored counts are the old ones, and the refresh was gone.restore-pending-videos.shnow also takes the open PR'sdata/videos.toml(unlessmainchanged it in the meantime, in which casemainwins and the next refresh catches up). The pages follow from that file.sign-commits,create-pull-requestsends all changed files in one API request, anddata/videos.tomlalone is 3.7 MB. The commits are now pushed with git instead. The repository rules don't require signed commits, and the squash merge intomainis signed by GitHub.Tested the restore script in a scratch repository: PR changed
videos.tomlandmaindidn't → restored; both changed →main's version; PR didn't change it →main's version; added files restored as before.Screenshots or previews (if applicable)
Not applicable.
Checklist
CONTRIBUTING.mdguidelines.