Skip to content

Keep the weekly stats refresh in the sync PR, and push it without signing - #495

Open
jeroenjanssens wants to merge 1 commit into
mainfrom
videos/keep-pending-sync-changes
Open

jeroenjanssens wants to merge 1 commit into
mainfrom
videos/keep-pending-sync-changes

Conversation

@jeroenjanssens

Copy link
Copy Markdown
Member

Prerequisite check

Related Issue

Follow-up to #486, based on the first nine nightly runs.

Description of changes

Two problems with the nightly video sync:

  1. The weekly stats refresh was undone the next night. On Monday the sync PR (Sync videos from YouTube #490) got refreshed view counts for 1,591 pages; Tuesday's run rebuilt the PR from main, whose stored counts are the old ones, and the refresh was gone. restore-pending-videos.sh now also takes the open PR's data/videos.toml (unless main changed it in the meantime, in which case main wins and the next refresh catches up). The pages follow from that file.
  2. The PR step failed on 2 of 9 nights ("Sorry, your request timed out. It's likely that your input was too large"). With sign-commits, create-pull-request sends all changed files in one API request, and data/videos.toml alone is 3.7 MB. The commits are now pushed with git instead. The repository rules don't require signed commits, and the squash merge into main is signed by GitHub.

Tested the restore script in a scratch repository: PR changed videos.toml and main didn't → restored; both changed → main's version; PR didn't change it → main's version; added files restored as before.

Screenshots or previews (if applicable)

Not applicable.

Checklist

  • My code/content builds locally without errors or warnings.
  • I have verified that all links and code blocks function properly.
  • This contribution aligns with the project's CONTRIBUTING.md guidelines.

…ning

- restore-pending-videos.sh also restores data/videos.toml from the open
  sync PR (unless main changed it since). The scripts keep the stored view
  counts on non-Monday nights, and the stored ones were main's, so
  Tuesday's run undid Monday's refresh of 1,591 pages.
- create-pull-request: sign-commits false. Signing sends every changed file
  in one API request, which timed out on 2 of the first 9 nights ("your
  input was too large"); a git push has no such limit.
@netlify

netlify Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for posit-open-source canceled.

Name Link
🔨 Latest commit e159288
🔍 Latest deploy log https://app.netlify.com/projects/posit-open-source/deploys/6b0222482052471d149c24f9

@github-actions

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant