Decide requirements generation from files present, not app mode - #84
Merged
Conversation
dotNomad
force-pushed
the
dotnomad/simplify-requirements-generation
branch
from
August 5, 2026 19:48
ea603ff to
d97671f
Compare
generate-requirements.sh now branches only on which files are in the working directory, and treats a missing dependency source as a no-op rather than an error. `posit connect deploy` already decides whether content needs a requirements.txt, and it does so precisely: it inspects the Python environment for a jupyter-engine Quarto doc but not a knitr-engine one, and never for Node.js. It raises a clear error naming the missing file when one is required. That makes needs_requirements unnecessary, so it comes out of AppType, resolve_app_type, the CLI output, and the deploy step's condition, along with REQUIREMENTS_DEPLOY_TYPES. Fixes #82. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dotNomad
force-pushed
the
dotnomad/simplify-requirements-generation
branch
from
August 5, 2026 19:49
d97671f to
979a51b
Compare
Contributor
|
Preview deployed to Connect ( Deployed from commit 979a51b. |
Contributor
|
Preview deployed to Connect ( Deployed from commit 979a51b. |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3941: 8 |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3940: 8 |
Contributor
|
Preview deployed to Connect ( Deployed from commit 979a51b. |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3942: 8 |
dotNomad
marked this pull request as ready for review
August 5, 2026 20:02
nealrichardson
approved these changes
Aug 5, 2026
nealrichardson
left a comment
nealrichardson
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-requirements.shnow branches only on which files are in the working directory, and a missing dependency source is a no-op instead of anexit 1.posit connect deployalready decides whether content needs arequirements.txt, and it does so more precisely than anapp_modelookup can: it inspects the Python environment for ajupyter-engineQuarto doc but not aknitr-engineone, and never for Node.js. When one is required and missing, it raises an error naming the file.That removes the reason for
needs_requirements, so it comes out ofAppType,resolve_app_type, the CLI output, and the deploy step'sif:condition, along withREQUIREMENTS_DEPLOY_TYPES.One case the
app_modegate got wrong and this fixes: aknitr-engineQuarto doc with no Python anywhere resolved toneeds_requirements=trueand failed at the generate step with "No uv.lock or pyproject.toml file found."Fixes #82.