Refactor UrlId into FilePath enum#1251
Open
lionel- wants to merge 4 commits into
Open
Conversation
lionel-
force-pushed
the
oak/salsa-14-canonicalisation
branch
from
0e6a188 to
eb2c844
Compare
lionel-
force-pushed
the
oak/salsa-15-file-path-refactor
branch
from
4ac9528 to
e807fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1250 (see that PR first for context)
Progress towards #1212
UrlIdtoFilePathUrlenum. Variants:File(lexically normalised) andVirtual(wrap anUrie.g. for untitled files). We could addVendoredlater for vendored base R sources, mirroring ty.This refactor better reflects that the main representation for our files are on-disk paths.