Repository navigation
Make the Posit AI Pass "Off" thinking option follow the capability table - #194
Merged
Merged
Conversation
…he capability table positAiThinkingRequestFields kept its own list of model IDs that get reasoning_effort "none" for thinking "off", separate from the Model APIs capability table that decides whether the picker offers "off". A model in the table but not the list showed an "Off" that sent nothing, so Baseten applied its default effort. This happened for DeepSeek V4 Flash, Kimi K3.1 Pro, and Kimi K3. The function now reads the model's thinkingEffortLevels from the table and sends "none" when "off" sits next to at least one named effort level. The ID list is gone, so for built-in models the picker and the wire cannot disagree. Behavior for every current model is unchanged. - Export getModelApisModelCapabilities from ai-config. - Document in the table that offering "off" next to named levels promises Baseten accepts "none". - Record the bridge reading the table as a named charter exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Posit AI Pass send thinking "Off" as
reasoning_effort: "none"based on the Model APIs capability table, instead of a separate list of model IDs. Behavior for every current model is unchanged.The table decides whether the picker offers "Off"; the list decided whether it was sent. A model in the table but not the list showed an "Off" that sent nothing, so Baseten applied its default effort. This happened three times (#88, #176, #192). The capability flag proposed in #191 would touch about 8 files in two repos, and a host that forgot to forward it would bring the bug back.
positAiThinkingRequestFields(packages/ai-provider-bridge/src/utils.ts) now sends"none"when the model's table entry offers "off" next to a named effort level. The charter says clients never infer capabilities from model IDs; the old list already did, somemory-bank/architecture.mdnow names this as an exception. Models added throughproviders.jsonare not in the table and can still show an "Off" that sends nothing, as before.After merge, bump the
packages/ai-libpin in the monorepo.