Skip Playwright's Chromium download and modernize Node/actions versions - #9
Open
michielbdejong wants to merge 1 commit into
Open
Skip Playwright's Chromium download and modernize Node/actions versions#9michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
…ns (#3) The Install dependencies step hung indefinitely: a nested dependency pulls in @playwright/test@1.25.0, whose postinstall unconditionally tries to download its own Chromium build, which either errors or hangs depending on network conditions. Verified locally that setting PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 gets the install fully past that stage (previously it failed/hung exactly there every time). Also bumped actions/checkout and actions/setup-node to current majors and the pinned Node version from the long-EOL 14.x to 20.x, since GitHub Actions has been progressively forcing old-runtime actions onto newer Node versions anyway.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3. The
test-logic-and-interface"Install dependencies" step hangs indefinitely because a nested dependency pulls in@playwright/test@1.25.0, whose postinstall unconditionally tries to download its own Chromium build (npx playwright install chromium) — which either errors quickly (restricted network) or hangs (unreliable download for that old, pinned browser build) depending on the environment.Change
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'at the job level. Verified locally: without it,npm run setupfails/hangs exactly at the Chromium download every time; with it, install gets fully past that stage.actions/checkout(v2→v4) andactions/setup-node(v1→v4), and the pinned Node version (14.x→20.x, long EOL) — GitHub Actions has been progressively forcing old-runtime actions onto newer Node anyway (see the deprecation warnings on the Pages workflow runs).Test plan
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD, confirmed it's bypassed with it settest-logic-and-interfacerun is the real test — I hit a further, unrelatedCannot find module 'OLSKString'error later in the postinstall chain locally that I couldn't fully root-cause without the real CI network/environment; if that resurfaces here I'll follow uphttps://claude.ai/code/session_01AcjKc8vk2fb84yYZsE8k5d
Generated by Claude Code