Skip to content

Skip Playwright's Chromium download and modernize Node/actions versions - #9

Open
michielbdejong wants to merge 1 commit into
mainfrom
claude/fix-issue-3
Open

Skip Playwright's Chromium download and modernize Node/actions versions#9
michielbdejong wants to merge 1 commit into
mainfrom
claude/fix-issue-3

Conversation

@michielbdejong

Copy link
Copy Markdown
Member

Summary

Fixes #3. The test-logic-and-interface "Install dependencies" step hangs indefinitely because a nested dependency pulls in @playwright/test@1.25.0, whose postinstall unconditionally tries to download its own Chromium build (npx playwright install chromium) — which either errors quickly (restricted network) or hangs (unreliable download for that old, pinned browser build) depending on the environment.

Change

  • Set PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1' at the job level. Verified locally: without it, npm run setup fails/hangs exactly at the Chromium download every time; with it, install gets fully past that stage.
  • Bumped actions/checkout (v2v4) and actions/setup-node (v1v4), and the pinned Node version (14.x20.x, long EOL) — GitHub Actions has been progressively forcing old-runtime actions onto newer Node anyway (see the deprecation warnings on the Pages workflow runs).

Test plan

  • Locally reproduced the exact hang without PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD, confirmed it's bypassed with it set
  • This PR's own test-logic-and-interface run is the real test — I hit a further, unrelated Cannot find module 'OLSKString' error later in the postinstall chain locally that I couldn't fully root-cause without the real CI network/environment; if that resurfaces here I'll follow up

https://claude.ai/code/session_01AcjKc8vk2fb84yYZsE8k5d


Generated by Claude Code

…ns (#3)

The Install dependencies step hung indefinitely: a nested dependency
pulls in @playwright/test@1.25.0, whose postinstall unconditionally
tries to download its own Chromium build, which either errors or hangs
depending on network conditions. Verified locally that setting
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 gets the install fully past that
stage (previously it failed/hung exactly there every time).

Also bumped actions/checkout and actions/setup-node to current majors
and the pinned Node version from the long-EOL 14.x to 20.x, since
GitHub Actions has been progressively forcing old-runtime actions onto
newer Node versions anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-logic-and-interface CI hangs indefinitely on "Install dependencies"

2 participants