Skip to content

Fix mixed-content livereload leak and Jekyll asset exclusion in static export #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michielbdejong merged 1 commit into from
Jul 24, 2026
+10 −1
Merged

Fix mixed-content livereload leak and Jekyll asset exclusion in static export #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion static-export.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ const OLSKStaticExportCopyBuiltAssets = function () {
fs.cpSync(path.join(kRootDirectory, 'os-app'), kOutputDirectory, {
recursive: true,
});

// Without this, GitHub Pages treats folders like `_shared` and
// `__compiled` as Jekyll-reserved and silently excludes them from
// serving, 404ing every asset underneath.
fs.writeFileSync(path.join(kOutputDirectory, '.nojekyll'), '');
};

const OLSKStaticExportMain = async function () {
Expand All @@ -140,7 +145,11 @@ const OLSKStaticExportMain = async function () {

const server = spawn('npm', ['start'], {
cwd: kRootDirectory,
env: Object.assign({}, process.env, { PORT: kPort }),
// NODE_ENV=production disables the dev-only livereload script
// (OLSKExpress/main.js), which would otherwise get baked into
// every crawled page and trip mixed-content blocking once served
// over HTTPS.
env: Object.assign({}, process.env, { PORT: kPort, NODE_ENV: 'production' }),
stdio: 'inherit',
detached: true,
});
Expand Down
Loading