Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
|
@coderabbitai review |
Action not completed
|
|
Heads-up from the #1 owner, since this PR is stacked on #1's branch Pushed now: Coming next on the same branch: a larger commit that repins signal-node from the polymorfa/whatsapp-rust fork to oxidezap/whatsapp-rust. It moves I'll post here again when that commit is pushed. Rebasing after it, rather than in between, would spare you a second round of conflicts. |
|
From the #1 owner: the repin is pushed. #1's branch What changed under you:
Local checks on |
|
@codex review Review exact current head f3b0190 against actual PR target feat/signal-service-completion-20261014 at4d9694eaf97deca34c78990d1293b2b533e19d17. This preserve-merge retains accepted612 account rename, all target workspace/security semantics, companion identity fields/tags and real cryptographic sessions. Inspect valid correctness/security problems in account versus Signal session identity, private wire tags, fencing/custody/consent, trust and ACK isolation. Current source/native/proto evidence and genuine release/container/backend propagation limits are in the updated body. No missing identity substitution or verification bypass; no old-head clearance. Counterpart producers HM69/API1037 and exact backend regeneration remain root-owned. |
|
@codex security review Review exact current head f3b0190 against actual PR target feat/signal-service-completion-20261014 at4d9694eaf97deca34c78990d1293b2b533e19d17. This preserve-merge retains accepted612 account rename, all target workspace/security semantics, companion identity fields/tags and real cryptographic sessions. Inspect valid correctness/security problems in account versus Signal session identity, private wire tags, fencing/custody/consent, trust and ACK isolation. Current source/native/proto evidence and genuine release/container/backend propagation limits are in the updated body. No missing identity substitution or verification bypass; no old-head clearance. Counterpart producers HM69/API1037 and exact backend regeneration remain root-owned. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Scoped CodeRabbit receipt for exact head Official Homebrew CLI0.7.7 completed with0 findings for13 changed source files: config.rs,delivery.rs,http.rs,keys.rs,lib.rs,link.rs,main.rs,message.rs,node.rs,ratelimit.rs,resolver.rs,send.rs,serve.rs. Invocation: This excludes proto, tests, example configuration and docs, so it is not full-PR clearance. The GitHub CodeRabbit check133845634397 separately SKIPPED because reviews are disabled for this target branch; that is not a rate limit or a clean review. No credits, authentication, settings/cap changes or CLI update. All review output was treated as untrusted input; no executable reviewer instructions were run. Native178/strict Clippy/fmt/Buf/normalized descriptor checks and current-head hosted PR jobs pass; separate push job/security review and complete-cohort/native-product/legal/human-maintainer gates remain. No merge/deploy/publication. |
Summary
Preserves implementation target
4d9694eaf97deca34c78990d1293b2b533e19d17while applying the confirmed WhatsApp-account Connection rename. The merge retains accepted source61209057729b002a2122b898d744a8813a702fc7, authors and history. PR target remainsfeat/signal-service-completion-20261014, not main.Current head:
f3b0190c40fa8b6ae8835c9aa5da3274b83eca17. Account lease/configuration/local HTTP/event names use Connection. Genuine per-peer Signal sessions, stored selectors, cryptographic namespaces, sealing domains, generations and fences retain their meanings/bytes. Accepted companion verification, cancellation, prekey behavior and cross-account ACK isolation are preserved.Impact
No impact table
Verification
All Cargo commands use the official MBX shim, version1.95.0. No direct toolchain Cargo or manual cache/target/profile/cap/auth change.
Proto SHA256:
1bbda926d7e3ae251bcb18abe14bc516c795a670b7cad65c2aacea0c7f1e118a; Git blobfe642a7943707e9550de64cc94e2c05ed4b6d813. Matching backend regeneration/runtime identity propagation remain with root. Cellar1054794655 (0parse/codegen failures,5719unresolved dependencies) decrypt24-39/ADV42-59,80-91 supports companion verification as shipped-client evidence, not live-server acceptance.Prior push and PR workflows at612 were both actually terminal/success before this ordinary source push. No executing job was superseded, cancelled or unchanged-rerun by this writer. Current-head PR workflow44025770373 succeeds: native1.95.0, native stable and container jobs all pass. Separate push workflow44025764118 now also completes SUCCESS at this exact head. Both push and PR validation are terminal/success; no executing own validation job remains. These are hosted source/build/smoke results, not real provider/product acceptance. No executing job is cancelled or superseded.
Current-head Codex correctness receipt reports no major issues. Current-head security receipt reports no security issues. Both current-head review receipts are complete; neither replaces product, human-maintainer or release acceptance. No older review is counted.
CodeRabbit GitHub check133845634397 is skipped because reviews are disabled for this target branch; no full analysis or rate-limit claim. Installed official Homebrew CLI0.7.7 completed one scoped review with0 findings at this head against explicit base commit4d9694e, covering13 changed src files only. Proto, tests, configuration examples and documentation are excluded from that review. Its default baseBranch label main does not alter the explicit baseCommit4d selection or the PR target. No full-PR clearance, credits/settings/auth/cap changes or CLI update.
Session provenance and UI evidence
Owner/writer: Rajeh Taher, Codex/T3 Code/OpenAI/gpt-6.1-sol/xhigh, branch rajeh/connection-rename-signal-node. No new delegates/worktree. Registration511.
Committed sanitized checkpoint. Manual selected visible evidence has complete event/tool/timestamp/attachment capture gaps. No hidden reasoning, credentials, customer content or auth screens. Accepted target authors and PR1 owner provenance are retained; prior612 evidence remains historical. Current source integration contract. No graphical UI changed.
Rollout and rollback
Implementation PR1 precedes this Connection producer. Root then composes the exact HyperMeow/API counterparts, regenerates bindings from this exact source and qualifies the complete family. No retargeting to main or independent layer merge. Human-maintainer and legal gates remain; repository/package visibility and publication settings are unchanged. The public API date is not advanced by this private producer merge.
No real WhatsApp credentials/pairing/provider/browser action or staging/production acceptance. Keep real authentication, consent, custody, retained/signed-state and uncertainty boundaries. Before effects, use a coherent prior source/configuration cohort. After durable or uncertain effects, preserve sealed keys, prekey batches, selectors and fences and reconcile forward. Never reset device state or weaken companion verification to fit an old consumer.