Skip to content

send: invalidate participant-hash caches for all recipient servers - #65

Merged
purpshell merged 1 commit into
codex/cat-refresh-without-callbackfrom
codex/participant-hash-cache-invalidation
Nov 12, 2026
Merged

purpshell merged 1 commit into
codex/cat-refresh-without-callbackfrom
codex/participant-hash-cache-invalidation

Conversation

@purpshell

@purpshell purpshell commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Split out of #53 so that PR stays a pure upstream sync. Stacked on #53.

SendMessage and SendFBMessage now share one helper that clears the cached device list or group route after a participant-hash mismatch. It covers the default, LID, bot, hosted, hosted-LID and Messenger servers in both send paths. Before this change, SendFBMessage skipped the LID, bot and hosted servers, and SendMessage skipped Messenger.

Test: TestParticipantHashInvalidationCoversForkRecipientServers; go test -race ./... passes.


Run Proof on this PR
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 5627b509-142e-4700-82f7-1828248bba98
Commits

Reviewing files that changed from the base of the PR and between 103811b and 6ff24b4.

Files selected for processing: 5

  • CHANGELOG.md
  • cache.go
  • participant_hash_invalidation_test.go
  • send.go
  • sendfb.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T14:48:24.120570Z 0f3bb58 Manual request
🔒 Security Review ✅ Completed 2026-11-12T14:49:58.790204Z 0f3bb58 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@purpshell
purpshell changed the base branch from codex/upstream-sync-20261027 to codex/unified-session-interval-lock November 12, 2026 12:57
@purpshell
purpshell force-pushed the codex/participant-hash-cache-invalidation branch from 251e5a1 to a1f2466 Compare November 12, 2026 12:58
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: a1f2466d4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: a1f2466d4c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@purpshell
purpshell force-pushed the codex/participant-hash-cache-invalidation branch from a1f2466 to f944078 Compare November 12, 2026 13:13
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: f944078f8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: f944078f8e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@purpshell
purpshell force-pushed the codex/participant-hash-cache-invalidation branch from f944078 to 0f3bb58 Compare November 12, 2026 14:46
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 0f3bb5813f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 0f3bb5813f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@purpshell
purpshell changed the base branch from codex/unified-session-interval-lock to codex/cat-refresh-without-callback November 12, 2026 14:58
@purpshell
purpshell added this pull request to stack #67 November 12, 2026 14:58
@purpshell
purpshell force-pushed the codex/participant-hash-cache-invalidation branch from 0f3bb58 to 6ff24b4 Compare November 12, 2026 19:30
@purpshell
purpshell merged commit 7ced325 into main Nov 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant