fix(mocktail): set FIRESTORE_PROJECT_ID on Zig collab service#39
Merged
Conversation
The collab binary reads FIRESTORE_PROJECT_ID and falls back to the local-emulator placeholder "demo-mocktail" if unset (firestore.zig:26). Without this env var the running container reports firestore: project=demo-mocktail host=firestore.googleapis.com:443 and every commit from a WS session would silently 404 against a nonexistent project. Pass var.project_id so the prod commit path targets firebase-cloud-491613.
Terraform Plan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collab binary reads
FIRESTORE_PROJECT_IDand falls back to"demo-mocktail"if unset. Production was missing the var so the running container logsfirestore: project=demo-mocktailand every Firestore commit from a WS session would silently 404. Passvar.project_id.Test plan
~ update in-placeonmodule.apps.google_cloud_run_v2_service.mocktailadding only the new env var.firestore: project=firebase-cloud-491613.