fix(shehryar): bootstrap Cloud Run with placeholder image#31
Merged
Conversation
The previous apply failed because the shehryar-api image isn't yet pushed to Artifact Registry. Use the public cloudrun/hello image as a bootstrap placeholder; once the shehryar repo's CI/CD pushes the real image and runs gcloud run deploy, lifecycle.ignore_changes prevents terraform from reverting back to the placeholder. Unblocks all future firebase-cloud applies.
Terraform Plan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks firebase-cloud terraform applies. PR #30 added the shehryar Cloud Run resource but its image (
shehryar-api:latest) isn't pushed to Artifact Registry yet, so apply fails with "Image not found." Use the publicgcr.io/cloudrun/helloimage as a bootstrap placeholder.When the shehryar repo's CI/CD eventually pushes the real image and runs
gcloud run deploy --image=..., the existinglifecycle.ignore_changes = [template[0].containers[0].image]keeps terraform from reverting back to the placeholder.Test plan
google_cloud_run_v2_service.shehryar_api(image change only) plus the IAM member that depends on itgcloud run services list --filter='name:shehryar-api'shows the service in READY state