Run JavaScript validation on the dbp branch - #10
Open
RonitBStudent wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow branch filters so the repository’s JavaScript validation runs on the default dbp branch (in addition to existing compatibility branches), and clarifies the Vite workflow’s displayed name.
Changes:
- Added
dbptopushandpull_requestbranch filters for the TypeScript and Vite workflows. - Added
dbpto the ESLint workflow’s existing[main, master]branch filters. - Renamed the Vite workflow to a distinct, descriptive name.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/vite.yml | Renames the workflow and adds dbp to branch triggers so Vite build runs on the default branch. |
| .github/workflows/typescript.yml | Adds dbp to branch triggers so TS tests/coverage run on the default branch. |
| .github/workflows/eslint.yml | Extends existing triggers to include dbp for linting on the default branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbpbranchmainandmastertriggers for compatibilityThe repository default branch is
dbp, but these workflows only subscribed tomain/master. As a result, normal changes to the active branch bypassed the project’s JavaScript validation.Validation
dbpis present for bothpushandpull_requestgit diff --check