Skip to content

Run JavaScript validation on the dbp branch - #10

Open
RonitBStudent wants to merge 1 commit into
poldracklab:dbpfrom
RonitBStudent:fix/restore-dbp-ci-coverage
Open

Run JavaScript validation on the dbp branch#10
RonitBStudent wants to merge 1 commit into
poldracklab:dbpfrom
RonitBStudent:fix/restore-dbp-ci-coverage

Conversation

@RonitBStudent

Copy link
Copy Markdown

Summary

  • run TypeScript tests, ESLint, and the production Vite build for pushes and PRs targeting the default dbp branch
  • retain the existing main and master triggers for compatibility
  • give the Vite workflow its own descriptive name instead of sharing the TypeScript workflow name

The repository default branch is dbp, but these workflows only subscribed to main/master. As a result, normal changes to the active branch bypassed the project’s JavaScript validation.

Validation

  • parsed all three workflows and verified dbp is present for both push and pull_request
  • verified the workflow names are unique
  • git diff --check

Copilot AI review requested due to automatic review settings August 3, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflow branch filters so the repository’s JavaScript validation runs on the default dbp branch (in addition to existing compatibility branches), and clarifies the Vite workflow’s displayed name.

Changes:

  • Added dbp to push and pull_request branch filters for the TypeScript and Vite workflows.
  • Added dbp to the ESLint workflow’s existing [main, master] branch filters.
  • Renamed the Vite workflow to a distinct, descriptive name.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/vite.yml Renames the workflow and adds dbp to branch triggers so Vite build runs on the default branch.
.github/workflows/typescript.yml Adds dbp to branch triggers so TS tests/coverage run on the default branch.
.github/workflows/eslint.yml Extends existing triggers to include dbp for linting on the default branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants