feat(safe-bash): expose curl response body intent to transports - #714
Open
kamilio wants to merge 1 commit into
Open
feat(safe-bash): expose curl response body intent to transports#714kamilio wants to merge 1 commit into
kamilio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl transports currently see the HTTP method but cannot tell whether curl will consume the response body. For example,
-I -X GETsends GET while omitting the body, and-fsuppresses HTTP error bodies. An eager browser transport can therefore read or reject a body that curl would never consume.Add optional
HttpRequest.responseBodyModewithread,omit, andomit-on-http-errorvalues. Curl supplies it at the shared transport call, preserving it across redirects and retries. Existing parsed flags determine the mode:-Iomits,-fomits only for status >= 400, and normal requests and--fail-with-bodyread. Omitted metadata defaults to read for other callers. Conflicting failure flags still reject before authorization, transport, or output-file effects.The transport method, parser, and response ownership are unchanged. This provides transport intent; it does not claim full native curl parity.
Validation against 0.1.535 (
b270fe04):Guarded root ESLint passed. CI packed public APIs passed on Node22 and Bun 1.3.11. The full Node22 virtual-bash unit suite passed. General CI passed build/lint/typecheck but its shared unit stage failed.
Current CI limitations:
navigatoris undefined, three toolcraft stream tests useArray.fromAsyncunder Node20, and the agent-harness coverage-demo replay test exceeds 5000ms. These failures remain unresolved; no runtime or timeout waiver was applied.gpt-6-astranot found).LLM not set; Goose reported an ACP internal error; OpenCode reported the fixture MCP tool unavailable. The same seven signatures occurred in earlier run 34433223443, whose source predates this metadata field. Goose/OpenCode root causes remain unresolved; this prior evidence does not waive the failures. No live retries or model/workflow changes were made.CI and review remain required before merge; this PR does not publish a release.