fix(safe-fs): compare device views in Worker runtimes - #710
Closed
kamilio wants to merge 1 commit into
Closed
Conversation
kamilio
marked this pull request as ready for review
September 10, 2026 01:51
Member
Author
|
Cherry-picked the portable device comparison fix as 7e4772a. Verified on remote main at 4da2a66 after local validation and final installed-package qualification. Closing after cherry-pick/reconciliation rather than merging obsolete branch history. Release is in progress: https://github.com/poe-platform/poe-code/actions/runs/34500155547 ; scoped packages: https://github.com/poe-platform/poe-code/actions/runs/34500155125 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device views fail in browser/Worker runtimes when an injected filesystem omits optional stable identity metadata. For example,
tree --noreport /exits 1 at/devwithcustom comparison authorities require Node context, preventing the shell from listing its virtual null device.Register the device view's internal comparison fallback, matching the existing mount view pattern. Device stats still establish alias identity; comparisons without sufficient evidence remain
unknown. Custom backend callbacks retain their existing Worker restriction. No Node shim or synthetic backing-file identity is introduced.Regression coverage runs the native graph and bundles both browser and workerd module selections, checking both comparison directions, device aliases, distinct devices, and cancellation. The real Workerd shell reproduction changed from exit 1 to exit 0, listing
/dev/nullwith empty stderr after applying the same one-line registration to an isolated copy of the published bundle.Validation:
The portable regression failed under both browser and workerd selection before the fix.
Screenshots
Local Worker regression: actual before/after results rendered in Chat; no model run.