issues/150: Added support for NRT filtering by granule id, minor fixes#178
Open
jackiryan wants to merge 2 commits into
Open
issues/150: Added support for NRT filtering by granule id, minor fixes#178jackiryan wants to merge 2 commits into
jackiryan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue: #150 , as well as #83 and a minor unticketed change
Description
As part of the work required to support MODIS L3 SST Daily collections, we need to be able to configure a regex to decide whether a granule gets delivered to GIBS in an NRT or Standard bucket. For these collections, NRT granules are mixed in with standard and are differentiated by filename where the former have a ".NRT" designation at the end.
Example: https://search.earthdata.nasa.gov/search/granules?p=C2036880650-POCLOUD&pg[0][v]=f&pg[0][gsk]=-start_date&q=MODIS%20AQUA%20L3%20SST
Overview of work done
nrtFilenameRegexkeyword to the dataset config allowing the provider to specify a regex to use for filtering NRT granules into a separate bucket for GIBS deliverycreate_dataset_config.pyscript andCONFIGURATION.mddocumentation to allow for datasets to be configured with new keyword:being used when creating filename creates issues on Mac and Linux #83 . This is an incredibly minor change so I just rolled it into this update.Overview of verification done
Unit tests have been updated to reflect the updated behavior in the handle_big_result lambda and are all passing.
SIT testing TBD. I specifically need to test configuring a daily MODIS collection and using the filename regex.
Overview of integration done
Integration testing is N/A and requires a UAT deployment and support from GITC Ingest team to see if our NRT bucket key will be handled appropriately. This can be tested with the rest of the updates in the main 0.8.0 release.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request