Repository navigation
Adopt typed results, multi-value secrets, and multi-repo projects in the adapter - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the four opportunities listed in #95 in
t3-adapter.mdand bumps the plugin to 0.17.4. No upstream file changes, sodrift.jsonis untouched.What changed
outputSchema. T3 queues it instead of steering it, and the child returns the result witht3_submit_output. After the completion wakes the root, it readsoutputwitht3_thread_waitand the send'srunId. A run that ended without submitting has nooutput.messageandoutputSchemareturns data thatt3_thread_waitreads asoutputwithuntilOutput: true.generateTitle: truenames the thread frommessage.titleis still required.fields, andsecret: falsefor a value the card may show. Fields always arrive as files, sovalueanddelivery: "secretRef"are left out. The result'sfilesmaps each fieldnameto its path.<workspace_folders>, a run can change a dependency in another listed repository from its own thread. Git and commits run per repository.pull_request_createopens a PR only from the thread's root folder, so a PR in another repository is opened with the resolved forge inside it, and the root links it.Facts taken from T3 at
9f9ebf6:runOutput.ts(schema checks, the instructions appended to the turn),docs/orchestration-v2/orchestrator-mcp-server.md(a send that asks for a result is queued, a turn can end without submitting),OrchestratorMcpService.ts(fieldsforces file delivery and rejectsvalueandsecretRef), thet3_thread_launchhandler (generateTitleneeds a message or attachments),docs/user/multi-repo-projects.md, and thepull_request_createhandler (cwdis the thread's worktree or the project root).Checks
bun run check,bun test tools --timeout 60000(40 pass), andbun run typecheckpass. With the default 5 s limit, threesyncfixture tests time out while the machine runs at a load average above 100. They pass with the longer limit and do not touch the adapter.