Fixes for condition checks - #1604
Merged
Merged
Conversation
Affected structures include soul capacitors, fasting challenge buildings, red universities, red factories, space casinos, and a couple of multisegmented projects. Resolves pmotschmann#1492. (Red factories + space casinos previously fixed on DeadSpace, removed by rebasing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
incrementStruct()function on several structures that weren't updated to use it. Resolves #1492.Fix condition checks for structures in the "City" region to include all expected checks by calling
checkRequirements()instead of duplicating the code.When purging structs for any reason, also purge from build queues. This is a general solution and is expected to supersede #1524, which also covers the most important known cases (cement plants and rock quarries) in a more manual way.
removeFromQueue()andremoveFromRQueue(). Pushing the "remove popper" changes into those functions for better reuse would be a reasonable request.Rebased version of #1532