A visual change is Chromatic's to report, not this job's - #189
Merged
Conversation
`chromatic-job` fails on a changed build today, which #186 introduced on purpose: a change nobody accepted should not read as green. It is the right rule enforced in the wrong place. Chromatic already posts a UI Tests check on the commit, red until the build is accepted, and it clears itself the moment someone accepts -- no re-run of anything. This job failing on top of that adds nothing and costs two things. A pull request that meant its change reads as broken rather than as waiting for review. And the one failure worth seeing here -- an upload that did not work, a token that expired, an archive that never arrived -- looks exactly like 68 snapshots pending review. So `--exit-zero-on-changes` off main: this job answers "did the upload work?", Chromatic answers "should this have changed?". This needs the Chromatic GitHub app installed on the repository -- it is what publishes UI Tests. Without it a changed build now reports nothing at all, which is how build 42 went green with a change waiting unreviewed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#186 made a changed Chromatic build fail
chromatic-job, so that a change nobody accepted could not read as green. Right rule, wrong place.Chromatic posts its own UI Tests check on the commit. It is red while a build has unaccepted changes and it clears itself the moment someone accepts -- no re-run of anything.
chromatic-jobfailing on top of that adds no signal and costs two:So
--exit-zero-on-changesoff main. This job answers "did the upload work?"; Chromatic answers "should this have changed?".--auto-accept-changeson main is unchanged.Before merging: the GitHub app
There is no UI Tests check on this repository today -- the check-runs on #166's head are the Actions jobs and nothing else, so the Chromatic GitHub app is not installed:
Until it is installed (chromatic.com -> the project -> Manage -> Integrations -> GitHub), this flag removes the gate rather than moving it: a changed build reports nothing at all, which is how build 42 went green with a change waiting unreviewed.
馃 Generated with Claude Code