fix: remove engines.node from published package (#165)#166
Merged
Conversation
The browser-only published library declared engines.node ">=24", which hard-fails consumer installs on Node 20/22 LTS under engine-strict (#165). The published dist only uses browser APIs (window, navigator, WebGL, fetch) and needs no Node runtime. The build/publish Node version is already pinned to 24 independently of this field via .nvmrc and the '24' node-version in both CI workflows, so dropping engines does not affect building or publishing. This restores the v6.0.0 behavior (no engines field). Fixes #165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since
v6.0.1,@pmndrs/detect-gpudeclaresengines.node: ">=24". Underengine-strict=truethis hard-fails consumer installs on Node 20/22 LTS:The library is browser-only — the published
distonly useswindow,navigator, WebGL andfetch, with no Node runtime requirement. The>=24constraint leaked in from a dev-environment bump (chore: bump node version to 24).Fix
Remove the
enginesfield entirely, restoring thev6.0.0behavior (which had noengines).The build/publish Node version is enforced independently of this field and is unaffected:
.nvmrc→24(local dev)node-version: '24'hard-pinned in both.github/workflows/test.ymlandrelease.ymlAlso removes the now-inaccurate "Node.js 24+" consumer requirement from the README.
Fixes #165