Skip to content

d3 v4 upgrade #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erosenberg wants to merge 2 commits into
base: 0.2.1-d3-upgrade
Choose a base branch
from
+10 −5
Open

d3 v4 upgrade #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db936ff
[Histogram] Change method of calculating x and y for d3 v4
Dec 20, 2016
478edd0
[Histogram] Add comments to go back to
Dec 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/Histogram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,13 @@ export default class Histogram extends React.Component {
}

componentWillMount() {
const histogramData = d3.layout.histogram().bins(30)(this.props.data);
//console.log('histogram', this.props.data, histogramData);
const histogram = d3.histogram()
.domain(this.props.domain.x)
.thresholds(30);

// why is `histogram` returning an array of length 40+ when it should be exactly 30???
const histogramData = histogram(this.props.data);

this.setState({histogramData});
}

Expand All @@ -35,9 +40,9 @@ export default class Histogram extends React.Component {

return <AreaBarChart
data={this.state.histogramData}
getX="x"
getXEnd={d => d.x + d.dx}
getY="y"
getX={d => d.x0}
getXEnd={d => d.x1}
getY={d => d.length}
{...{name, scale, axisType, scaleWidth, scaleHeight, plotWidth, plotHeight}}
/>;
}
Expand Down