Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .agents/agents/fw-compat-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ the same SONAME on every release from 2.2.3 to 11.2.0. Moving a library
into `dynlib!` **trades link-time symbol checking away** for version tolerance and is only worth
it where the version actually varies. If a diff moves a stable library there, push back and ask
for the `--inventory` output that justifies it. The precedent for the other direction is
`textinput.rs`: plain `extern "C"`, justified in its module doc by all 14 inventories exporting the
whole `SDL_*TextInput*` family.
`rust-modules/shell-sdl/src/sys.rs`: plain `extern "C"` (the `SDL_*TextInput*` calls among them),
justified in its module doc by all 14 inventories exporting the whole SDL2 family it names.

## WHAT `fwcompat.py` NEEDS BEFORE IT WILL ANSWER — settle this first, not at your third command

Expand Down Expand Up @@ -163,7 +163,7 @@ git -C <repo> diff HEAD -- rust-modules/base/src/dynlib.rs rust-modules/media-co
rust-modules/net/src/net.rs rust-modules/net/src/curlio.rs src/starfish.c src/video_plane.c src/starfish.h \
rust-modules/os/src/webos.rs rust-modules/os/src/webos/ls2/uri.rs Makefile \
ci/expected-dt-needed.txt ci/expected-dt-needed-uri.txt
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/os/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/shell-sdl/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/os/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
```

### 1. Decide, out loud, whether you are grading an ELF or grading source
Expand Down Expand Up @@ -260,7 +260,7 @@ Reading the output:
C++11 `std::string` ABI and are untested on a set apart from one 3.4.3 (webOS 1.x/2.x were never
tried). They used to fail on two missing symbols, `SDL_webOSCursorVisibility` and
`StarfishMediaAPIs::Feed`'s C++11 name, but since #578 both are `dlsym`'d at runtime
(`src/starfish.c`, `rust-modules/src/app/boot.rs`, and `rust-modules/src/system.rs`'s `cursor_door`), so the binary no longer imports them. Re-run
(`src/starfish.c`, and `rust-modules/src/system.rs`'s `webos3_cursor_sleep_hint` and `cursor_door`), so the binary no longer imports them. Re-run
`tools/fwcompat.py` for what the old rows print now; they are still printed below the floor and
do not set the exit status.
* **Baseline as of 2026-08-23** (verified by running it): `15 DT_NEEDED, 319 undefined dynamic
Expand Down
2 changes: 1 addition & 1 deletion .agents/skills/ui-sim/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ state. Close other WSL work, run `wsl.exe --shutdown`, and retry; accept the run
`use_gfxredir = 1`.

**Ask for `SIM_W=1920 SIM_H=1080` on any shot you intend to JUDGE.** The window is otherwise sized
to fit the display (`app::boot::plan_desktop_window`), and on a 1x screen that divisor lands on 2, so
to fit the display (`plx_shell_sdl::window::plan_desktop_window`), and on a 1x screen that divisor lands on 2, so
every screenshot comes back 960x540 — half the canvas the UI is authored at. A 1px edge-sheen, a
hairline, a snapped glyph and a specular rim are exactly the things that do not survive that
halving, which makes a shot at the default size evidence about layout and nothing else. The size is
Expand Down
4 changes: 2 additions & 2 deletions .agents/skills/which-tier/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ but a photograph could show it (`gfx.rs`, at the `glBlendFuncSeparate` call).

### Tier 1 — `make check`

`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`ifs_same_cond`, `same_functions_in_if_condition`, `if_same_then_else` — the shadowed-branch gate),
and followed by **three** host checks that are easy to forget are in here: `python3 ci/flavor.py
--selftest` (the flavour transform, whose central assertion is that the STABLE transform is the
Expand Down Expand Up @@ -108,7 +108,7 @@ lock.) Do not write a new number here: measure it if you need one — this file
Count it yourself if you need the number:

```sh
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp -- --list | grep -c ': test'
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp -- --list | grep -c ': test'
```

**Run it on the pinned toolchain.** `make check` uses `cargo +$(RUST_TOOLCHAIN)`, the `channel` of
Expand Down
1 change: 1 addition & 0 deletions .claude/hooks/release-config-check-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def edit(path, tool="Edit", key="file_path", **extra):
(FIRE, "the media layer crate\\'s source", edit("/repo/rust-modules/media/src/player/mod.rs"), ROOT),
(FIRE, "the appkit layer crate\\'s source", edit("/repo/rust-modules/appkit/src/player_hud/mod.rs"), ROOT),
(FIRE, "the screens layer crate\\'s source", edit("/repo/rust-modules/screens/src/home/mod.rs"), ROOT),
(FIRE, "the shell_sdl layer crate's source", edit("/repo/rust-modules/shell-sdl/src/window.rs"), ROOT),
(FIRE, "MultiEdit", edit("/repo/rust-modules/src/app/run.rs", tool="MultiEdit"), ROOT),
(FIRE, "relative to root", edit("rust-modules/src/route.rs"), ROOT),
(FIRE, "relative to a subdir", edit("src/plex/client.rs"), "/repo/rust-modules"),
Expand Down
2 changes: 1 addition & 1 deletion .claude/hooks/release-config-check.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def rust_src_target(payload, root, cwd=None):
src = os.path.realpath(os.path.join(root, "rust-modules", "src"))
# The layer crates split out of `src` (docs/module-layers.md) are compiled by the same
# `cargo check --lib` as a dependency, so an edit there is a release-configuration risk too.
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "os", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens")]
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "os", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens", "shell-sdl")]
if not any(path.startswith(s + os.sep) for s in [src] + layer_srcs):
return None
# `--lib` compiles no bin target, and `sim.rs` needs `hostsim`, which the release set never has.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
# (`cargo metadata` resolves; it compiles nothing), plus an informational line count.
# The binary-size budget runs in cross-build, where the binary exists. Limits and how to
# raise one deliberately: ci/build-budgets.json, docs/agent-reference.md.
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/os/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/owp/src
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/os/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/shell-sdl/src --src rust-modules/owp/src

- name: Third-party notices vs the ARM runtime graph
# `make check` runs only the OFFLINE half of this (ci/gen-third-party-notices.py --check), which
Expand Down Expand Up @@ -310,7 +310,7 @@ jobs:
# for plxnative-modules both ways), so the `cargo test --lib` below finds everything built
# and this step is where the compile happens, not an extra one. The upload below carries it.
shell: bash
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --no-run --timings
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp --no-run --timings

- name: make check-cargo-unit-default
# Teed to a file so the size step below can read the `test result:` lines this run already
Expand Down
16 changes: 8 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,7 @@ $(FFABI_STAMP): ci/ffabi-assert.c $(FFMPEG_INC)/libavformat/avformat.h Makefile
# rule would leave every later `make` linking a library built by the OLD one. Cargo's own
# `rerun-if-changed` cannot save that — it is only consulted when make decides to invoke cargo at
# all, and this target is an ordinary timestamp comparison.
RUST_INPUTS := $(shell find rust-modules/src rust-modules/base rust-modules/machine rust-modules/net rust-modules/os rust-modules/gfx rust-modules/ui rust-modules/plex rust-modules/telemetry rust-modules/data rust-modules/session rust-modules/media rust-modules/playback-contract rust-modules/play-uri rust-modules/play-feed rust-modules/media-codecs rust-modules/appkit rust-modules/screens rust-modules/build_support locales assets -type f 2>/dev/null)
RUST_INPUTS := $(shell find rust-modules/src rust-modules/base rust-modules/machine rust-modules/net rust-modules/os rust-modules/gfx rust-modules/ui rust-modules/plex rust-modules/telemetry rust-modules/data rust-modules/session rust-modules/media rust-modules/playback-contract rust-modules/play-uri rust-modules/play-feed rust-modules/media-codecs rust-modules/appkit rust-modules/screens rust-modules/shell-sdl rust-modules/build_support locales assets -type f 2>/dev/null)
$(RUST_LIB): LICENSE $(RUST_INPUTS) rust-modules/Cargo.toml rust-modules/Cargo.lock rust-modules/build.rs ci/install-identities.json rust-modules/.cargo/config.toml Makefile ci/check-staticlib-artifact.py $(FFABI_STAMP)
@# BEFORE the mkdir: the seed is only ever cloned into a target dir that does not exist yet.
$(CARGO_SEED) restore $(RUST_TDIR) rust-modules/$(RUST_TDIR)
Expand Down Expand Up @@ -1717,7 +1717,7 @@ check-cargo-lint: lint
@# gate has nothing to reuse a cache for. No `pkg/lab.json` is involved — that file is `make
@# LAB=1`'s requirement (a live session secret), not the compiler's.
@set -e; cd rust-modules && CARGO_INCREMENTAL=0 PATH="$$HOME/.cargo/bin:$$PATH" \
cargo +$(RUST_TOOLCHAIN) check --lib --tests -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --features lab-diagnostics
cargo +$(RUST_TOOLCHAIN) check --lib --tests -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp --features lab-diagnostics
@# And the demo-video dump build's pixel oracle, `placeholder-sentinel`: in no default set and
@# built only by `make site-video-sim`, which no gate runs and which compiles no `plx_ui` tests, so
@# this line is what keeps it compiling (its code AND its tests, `--tests`). `plx_ui` is the only
Expand All @@ -1736,7 +1736,7 @@ check-cargo-lint: lint
# `-p` lists in the recipes below (those stay literal because ci/test_ci_split.py greps for them);
# ci/test_test_crate.py pins the two equal.
UNIT_RUN = python3 ../tools/cargo-test-parallel.py
UNIT_SUITE = plxnative-modules plx_base plx_machine plx_os plx_gfx plx_net plx_ui plx_plex plx_telemetry plx_data plx_session plx_media plx_playback_contract plx_play_uri plx_play_feed plx_media_codecs plx_appkit plx_screens plx_owp
UNIT_SUITE = plxnative-modules plx_base plx_machine plx_os plx_gfx plx_net plx_ui plx_plex plx_telemetry plx_data plx_session plx_media plx_playback_contract plx_play_uri plx_play_feed plx_media_codecs plx_appkit plx_screens plx_shell_sdl plx_owp
# The `hostsim` pass runs only the crates that DECLARE a `hostsim` feature (HOSTSIM_SUITE, a subset of
# UNIT_SUITE in the same order; ci/test_test_crate.py pins both the subset and the recipe). The eight that
# do not (plx_net, plx_ui, plx_appkit, plx_screens, plx_media_codecs, plx_play_uri, plx_playback_contract,
Expand All @@ -1748,7 +1748,7 @@ UNIT_SUITE = plxnative-modules plx_base plx_machine plx_os plx_gfx plx_net plx_u
# none of their tests observes those dependency-side differences; the guard does not check that, it
# checks that the crate declares no `hostsim` feature and has no `feature = "hostsim"` in its src, and
# fails when one gains either, which is the moment it must join the list.
HOSTSIM_SUITE = plxnative-modules plx_base plx_machine plx_os plx_gfx plx_plex plx_telemetry plx_data plx_session plx_media plx_play_feed
HOSTSIM_SUITE = plxnative-modules plx_base plx_machine plx_os plx_gfx plx_plex plx_telemetry plx_data plx_session plx_media plx_play_feed plx_shell_sdl

# The default-feature unit suite and everything that drives cargo through ci/ self-tests.
check-cargo-unit-default:
Expand Down Expand Up @@ -1777,7 +1777,7 @@ check-cargo-unit-default:
cd rust-modules && PATH="$$HOME/.cargo/bin:$$PATH" PLXNATIVE_RUNTIME_DIR="$$d" \
$(TELEMETRY_ENV) \
$(HOST_ENV) \
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp
RUST_TOOLCHAIN=$(RUST_TOOLCHAIN) python3 ci/test_storage_service_package.py
cd rust-modules && PATH="$$HOME/.cargo/bin:$$PATH" cargo +$(RUST_TOOLCHAIN) test -p plxnative-storage --bin plxnative-storage
@# The helper is its own package, so building it compiles no copy of the app library; this reads
Expand Down Expand Up @@ -1811,7 +1811,7 @@ check-cargo-unit-hostsim:
cd rust-modules && PATH="$$HOME/.cargo/bin:$$PATH" PLXNATIVE_RUNTIME_DIR="$$d" \
$(TELEMETRY_ENV) \
$(HOST_ENV) \
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_play_feed --features hostsim
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_play_feed -p plx_shell_sdl --features hostsim

# OPT-IN incremental inner loop: the default-feature unit suite (the same `cargo test --lib` as
# `check-cargo-unit-default`, same throwaway runtime root and telemetry env) with
Expand All @@ -1835,7 +1835,7 @@ test-fast:
PATH="$$HOME/.cargo/bin:$$PATH" PLXNATIVE_RUNTIME_DIR="$$d" \
$(TELEMETRY_ENV) \
$(HOST_ENV) \
$(UNIT_RUN) $(if $(T),--filter '$(T)') -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp
$(UNIT_RUN) $(if $(T),--filter '$(T)') -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp

# `make test-crate C=plx_ui [T=filter] [DEPS=1]` -- build and run ONLY the named crate's lib tests, in
# the same incremental `$(TEST_FAST_TDIR)` tree and with the same flags as `test-fast`, so the two
Expand Down Expand Up @@ -2471,7 +2471,7 @@ SIM_SHOT ?= $(SIM_DIR)/shot.png
# reason BOOT_SH exists for `run`/`run-stream`.
# Size of the simulator's DRAWABLE in pixels, 1:1 on any pixel density (the window is ALLOW_HIGHDPI, so
# on a Retina display it is half this many points; `fit_window_to_density` does the conversion).
# Empty = fit the display (see `plan_desktop_window`), which on a 1x screen is half the authored
# Empty = fit the display (see `plx_shell_sdl`'s `plan_desktop_window`), which on a 1x screen is half the authored
# canvas and therefore half the resolution of every screenshot. Set both to look at the UI the
# size it is drawn:
# make sim-shot SIM_W=1920 SIM_H=1080
Expand Down
2 changes: 1 addition & 1 deletion ci/build-budgets.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"headroom": "+3"
},
"source_lines": {
"what": "Lines of Rust under rust-modules/src, rust-modules/base/src, rust-modules/machine/src, rust-modules/net/src, rust-modules/os/src, rust-modules/gfx/src, rust-modules/ui/src, rust-modules/plex/src, rust-modules/telemetry/src, rust-modules/data/src, rust-modules/session/src, rust-modules/media/src, rust-modules/playback-contract/src, rust-modules/media-codecs/src, rust-modules/play-feed/src, rust-modules/play-uri/src, rust-modules/appkit/src, rust-modules/screens/src and rust-modules/owp/src (every .rs file). Informational: exceeding it warns and never fails, because a growing feature is not a build-health defect by itself.",
"what": "Lines of Rust under rust-modules/src, rust-modules/base/src, rust-modules/machine/src, rust-modules/net/src, rust-modules/os/src, rust-modules/gfx/src, rust-modules/ui/src, rust-modules/plex/src, rust-modules/telemetry/src, rust-modules/data/src, rust-modules/session/src, rust-modules/media/src, rust-modules/playback-contract/src, rust-modules/media-codecs/src, rust-modules/play-feed/src, rust-modules/play-uri/src, rust-modules/appkit/src, rust-modules/screens/src, rust-modules/shell-sdl/src and rust-modules/owp/src (every .rs file). Informational: exceeding it warns and never fails, because a growing feature is not a build-health defect by itself.",
"unit": "lines",
"mode": "warn",
"limit": 485000,
Expand Down
Loading
Loading