Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 4 additions & 4 deletions .agents/agents/fw-compat-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: >
Use before pushing anything that edits `rust-modules/base/src/dynlib.rs`,
`rust-modules/media-codecs/src/ffi.rs`, `rust-modules/media-codecs/src/venc.rs`,
`rust-modules/net/src/net.rs`, `rust-modules/net/src/curlio.rs`,
`src/starfish.c`, `src/video_plane.c`, `src/starfish.h`, `rust-modules/platform/src/webos/ls2/uri.rs`,
`src/starfish.c`, `src/video_plane.c`, `src/starfish.h`, `rust-modules/os/src/webos/ls2/uri.rs`,
`rust-modules/play-uri/src`, `ci/expected-dt-needed.txt`,
`ci/expected-dt-needed-uri.txt`, the Makefile's `LIBS_REAL`, `PLAYBACK_BACKENDS` or
`PLAYBACK_HAS_FEED`, or that adds any
Expand Down Expand Up @@ -57,7 +57,7 @@ In scope if the diff touches any of:
| `rust-modules/net/src/curlio.rs` | the byte-range `curl_multi_*` `dynlib!` table, exposed as `net::range_io` |
| `src/starfish.c` | 15 mangled C++ externs against real libraries (built only when `PLAYBACK_HAS_FEED`) |
| `src/video_plane.c`, `src/starfish.h` | the video-plane binding: its own `dlopen` of ACB, the `dlsym` probe for the SDL exported window, and `vp_mode()` choosing between them; the header declares the `acb_*` / `sf_*` seam the Rust externs mirror |
| `rust-modules/platform/src/webos/ls2/uri.rs` and the `LSCall` declaration in `webos.rs` | the `com.webos.media` LS2 worker; `LSCall` is a hard import of `libluna-service2` in every build with the platform feature `uri-transport`, which the application's `play-uri` feature (in the shipping set) turns on |
| `rust-modules/os/src/webos/ls2/uri.rs` and the `LSCall` declaration in `webos.rs` | the `com.webos.media` LS2 worker; `LSCall` is a hard import of `libluna-service2` in every build with the os crate's feature `uri-transport`, which the application's `play-uri` feature (in the shipping set) turns on |
| `rust-modules/play-uri/src` | the URI backend declares no `extern "C"` of its own: it reaches ACB through `DisplaySink` (the platform's `acb_*` externs) and the bus through `tv::uri::UriMedia`; a declaration appearing here is a new undefined symbol and a layer violation |
| any new `extern "C"` block, `#[link]`, or `__asm__("<mangled>")` declaration | each one adds an undefined symbol, or a whole `DT_NEEDED` entry |
| `Makefile`'s `LIBS_REAL` and the link rule that uses it | a new `-l` is a new hard `DT_NEEDED` |
Expand Down Expand Up @@ -161,9 +161,9 @@ grade an ELF at all.
git -C <repo> diff --stat HEAD # or the range under review
git -C <repo> diff HEAD -- rust-modules/base/src/dynlib.rs rust-modules/media-codecs/src/ffi.rs rust-modules/media-codecs/src/venc.rs \
rust-modules/net/src/net.rs rust-modules/net/src/curlio.rs src/starfish.c src/video_plane.c src/starfish.h \
rust-modules/platform/src/webos.rs rust-modules/platform/src/webos/ls2/uri.rs Makefile \
rust-modules/os/src/webos.rs rust-modules/os/src/webos/ls2/uri.rs Makefile \
ci/expected-dt-needed.txt ci/expected-dt-needed-uri.txt
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/platform/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/os/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
```

### 1. Decide, out loud, whether you are grading an ELF or grading source
Expand Down
4 changes: 2 additions & 2 deletions .agents/skills/which-tier/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ but a photograph could show it (`gfx.rs`, at the `glBlendFuncSeparate` call).

### Tier 1 — `make check`

`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`ifs_same_cond`, `same_functions_in_if_condition`, `if_same_then_else` — the shadowed-branch gate),
and followed by **three** host checks that are easy to forget are in here: `python3 ci/flavor.py
--selftest` (the flavour transform, whose central assertion is that the STABLE transform is the
Expand Down Expand Up @@ -108,7 +108,7 @@ lock.) Do not write a new number here: measure it if you need one — this file
Count it yourself if you need the number:

```sh
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp -- --list | grep -c ': test'
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp -- --list | grep -c ': test'
```

**Run it on the pinned toolchain.** `make check` uses `cargo +$(RUST_TOOLCHAIN)`, the `channel` of
Expand Down
2 changes: 1 addition & 1 deletion .claude/hooks/release-config-check-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def edit(path, tool="Edit", key="file_path", **extra):
(FIRE, "Write", edit("/repo/rust-modules/src/dev.rs", tool="Write"), ROOT),
(FIRE, "a layer crate's source", edit("/repo/rust-modules/base/src/paths.rs"), ROOT),
(FIRE, "the machine layer crate's source", edit("/repo/rust-modules/machine/src/idle.rs"), ROOT),
(FIRE, "the platform layer crate's source", edit("/repo/rust-modules/platform/src/webos.rs"), ROOT),
(FIRE, "the os layer crate's source", edit("/repo/rust-modules/os/src/webos.rs"), ROOT),
(FIRE, "the gfx layer crate's source", edit("/repo/rust-modules/gfx/src/gfx.rs"), ROOT),
(FIRE, "the net layer crate's source", edit("/repo/rust-modules/net/src/net.rs"), ROOT),
(FIRE, "the ui layer crate's source", edit("/repo/rust-modules/ui/src/widgets.rs"), ROOT),
Expand Down
2 changes: 1 addition & 1 deletion .claude/hooks/release-config-check.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def rust_src_target(payload, root, cwd=None):
src = os.path.realpath(os.path.join(root, "rust-modules", "src"))
# The layer crates split out of `src` (docs/module-layers.md) are compiled by the same
# `cargo check --lib` as a dependency, so an edit there is a release-configuration risk too.
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "platform", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens")]
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "os", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens")]
if not any(path.startswith(s + os.sep) for s in [src] + layer_srcs):
return None
# `--lib` compiles no bin target, and `sim.rs` needs `hostsim`, which the release set never has.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
# (`cargo metadata` resolves; it compiles nothing), plus an informational line count.
# The binary-size budget runs in cross-build, where the binary exists. Limits and how to
# raise one deliberately: ci/build-budgets.json, docs/agent-reference.md.
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/platform/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/owp/src
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/os/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/owp/src

- name: Third-party notices vs the ARM runtime graph
# `make check` runs only the OFFLINE half of this (ci/gen-third-party-notices.py --check), which
Expand Down Expand Up @@ -309,7 +309,7 @@ jobs:
# for plxnative-modules both ways), so the `cargo test --lib` below finds everything built
# and this step is where the compile happens, not an extra one. The upload below carries it.
shell: bash
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --no-run --timings
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --no-run --timings

- name: make check-cargo-unit-default
# Teed to a file so the size step below can read the `test result:` lines this run already
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ the macOS simulator are valuable, but they cannot prove every device behavior.
`ci/module-layers.ini` declares the crates `rust-modules/src` is being split into, and
`ci/check-module-layers.py` (in `make check`) fails on a reference that names a layer its own
layer may not use, on a module placed in no layer, and on a reference from outside
`[port webos]` to `webos`, `keymanager`, `system` or `port`. Fix the reference
`[platform webos]` to `webos`, `keymanager`, `system` or `port`. Fix the reference
(`docs/module-layers.md` says where code belongs and how to cut an upward name) instead of
adding a (file, member) pair to `ci/allow/layers.txt`, which is empty and only shrinks.
- **Logic never performs IO.** A machine (a screen, a `data/` store, the session owner, the player's
Expand Down
Loading
Loading