Skip to content

[v0.10] Media: the window-reread test times its wait from before the stop's sleep (flaky on loaded runners) - #1467

Merged
GLinnik21 merged 1 commit into
release/v0.10from
backport/1382-to-v0.10
Nov 19, 2026
Merged

GLinnik21 merged 1 commit into
release/v0.10from
backport/1382-to-v0.10

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Backport of #1382 to release/v0.10: git cherry-pick -x a3ea02c1f260.

…leep (#1382)

the_window_reread_waits_for_the_outgoing_stop_within_its_bound started its clock inside the spawned reader thread, while the 250 ms sleep before stop.finish() runs on the test thread right after the spawn. A reader scheduled late began timing after the sleep had started, so a read that correctly waited for the stop measured under 250 ms. CI's hostsim job failed on it on 2026-11-12 and 2026-11-14 ("it waited for the stop: 249.3ms").

The clock now starts before std::thread::scope, so a correct wait always measures at least 250 ms. The bound, the assertion and the window_reads() checks are unchanged. A 50 ms delay injected at the start of the reader fails the old code (204 ms) and passes the new one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit a3ea02c)
@GLinnik21
GLinnik21 merged commit 3045083 into release/v0.10 Nov 19, 2026
22 checks passed
@GLinnik21
GLinnik21 deleted the backport/1382-to-v0.10 branch November 19, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant