Repository navigation
[v0.10] Media: the window-reread test times its wait from before the stop's sleep (flaky on loaded runners) - #1467
Merged
Conversation
…leep (#1382) the_window_reread_waits_for_the_outgoing_stop_within_its_bound started its clock inside the spawned reader thread, while the 250 ms sleep before stop.finish() runs on the test thread right after the spawn. A reader scheduled late began timing after the sleep had started, so a read that correctly waited for the stop measured under 250 ms. CI's hostsim job failed on it on 2026-11-12 and 2026-11-14 ("it waited for the stop: 249.3ms"). The clock now starts before std::thread::scope, so a correct wait always measures at least 250 ms. The bound, the assertion and the window_reads() checks are unchanged. A 50 ms delay injected at the start of the reader fails the old code (204 ms) and passes the new one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit a3ea02c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1382 to
release/v0.10:git cherry-pick -x a3ea02c1f260.