Skip to content

Flaky: app::diagnostics::tests::an_unknown_firmware_is_named_as_unknown reads Resolving #1179

Closed

Description

@Bardioc1977

Observed once in six runs of the whole default-feature app test binary at host load ~90: src/app/diagnostics.rs:3440, left: "Resolving" right: "Idle".
Cause: player::state() (media/src/player/mod.rs:776) answers Resolving before it looks at the pump state for route::play_pending(), route::engineless_flight_outstanding() or SHARED.start_queued. The test holds serial() and re-establishes the pump state, seeking, the claim hold and the play verdict, but none of those three, so a value left by another test shows through. Forced: setting SHARED.start_queued before the body gives exactly the failure above.
Leaker: not identified. A candidate is SHARED.start_queued, a process-global mirror written by every PlayerAdapter in release_step (adapter.rs:178); a test whose adapter ends with a queued start leaves it true. Another is any test that calls request_play and ends without cancel_play or a landing (PLAY_BUSY).
Fix: clear and hand back the play mailbox and the queued start in the test, and print all three inputs in the assertion message so a remaining leaker (the engine-less flight cannot be cleared from a test) names itself.

Credit: found by Claude Fable 5.1 while reproducing #1001 (run 3 of 6 at host load about 90); the forcing and the fix are ours.

Activity

  1. added
    bugSomething isn't working
    playbackPlayback, the player and its controls
    user-reportReported by a user of a released build
    on Oct 31, 2026
  2. added
    internalTooling, CI, tests and code health; no user-facing change
    and removed
    bugSomething isn't working
    playbackPlayback, the player and its controls
    on Oct 31, 2026
  3. Bardioc1977 commented on Nov 2, 2026

    @Bardioc1977
    ContributorAuthor

    Fixed by #1189: the season-menu rig now cancels its pending play and joins the resolve worker, which was the leaker, and the diagnostics test establishes its inputs itself. I closed my PR (#1184) as superseded; this issue can be closed as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    internalTooling, CI, tests and code health; no user-facing change

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions