You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Flaky hostsim test: an end of stream can still be on the player when the lifecycle test checks the route #1111
app::run::lifecycle_regression_tests::an_end_of_stream_without_up_next_returns_to_the_detail_page failed once in CI's host unit tests (hostsim) job on PR #1108 (run 40687822993) and passed on the re-run of the same head:
thread '...an_end_of_stream_without_up_next_returns_to_the_detail_page' panicked at src/app/run.rs:7730:9:
end of stream landed on ScreenId(11), not the detail page
test result: FAILED. 1201 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 60.48s
ScreenId(11) is AppArg::Player. When the test checked the route, the session's exit had not finished: the route was still on the player after settle.
On that head, the test passed 3/3 alone (make test-hostsim T=...) and the full app-crate hostsim suite passed 2/2 locally.
It had not failed in the previous 60 CI runs.
So it looks timing-dependent on a loaded runner. The suspect is the step between SHARED.ended and the route leaving the player (finish_playback -> exit_player), and whether settle waits for it, or only for a fixed number of frames or a wall-clock budget.
Done when:
the test waits for the exit itself, not for elapsed time or a frame count, or the race is shown to be in the app and fixed;
a run with the suite under load (for example, the hostsim suite alongside a second cargo build) passes repeatedly.
Activity