-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add workbench actions #3910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maciaszczykm
wants to merge
51
commits into
master
Choose a base branch
from
marcin/prod-5064-adding-workbench-k8s-action-designs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
35ddfc2
update client
maciaszczykm c7c4bd9
add icons
maciaszczykm 37132d1
add new custom actions
maciaszczykm a415135
add approval setting
maciaszczykm 4c6f719
add missing query
maciaszczykm d6fd2b4
update awaiting review panel
maciaszczykm 67f9547
regenerate client
maciaszczykm 127ccff
regenerate client
maciaszczykm 1bf2924
fix server code
maciaszczykm 6c31ece
update query
maciaszczykm 045f9b6
update workbench tooltip
maciaszczykm f7ec888
update lightning icon
maciaszczykm 7dcfef0
initialize actions tab
maciaszczykm 240d8df
fix panel content check
maciaszczykm 8a6af64
allow activities filtering
maciaszczykm cfc1e7c
add pending actions icon
maciaszczykm 6f1acd6
fix activity rejection
maciaszczykm 2a54607
initial list action implementation
maciaszczykm 8db02ce
fix tool form
maciaszczykm 1c86a2c
update action buttons
maciaszczykm f78c536
add status chip
maciaszczykm a2724c6
add deny modal with optional reason field
maciaszczykm 032513f
show action tab only if not empty
maciaszczykm 2220bed
update styling
maciaszczykm 29260db
update styling
maciaszczykm e21a27f
update icon
maciaszczykm 7cf6469
handle all statuses
maciaszczykm 53360c8
add cards in chat
maciaszczykm add8584
update actions
maciaszczykm c98c2b5
refactor
maciaszczykm 6d09bcb
store info about user rejecting action
maciaszczykm 80e7b47
add denial result
maciaszczykm 3d8ad0d
style error display
maciaszczykm d48408b
update cards
maciaszczykm 5cfca4a
update deny popover
maciaszczykm f196497
update card borders
maciaszczykm 319824f
add configure actions step
maciaszczykm c8463d2
fix chip list
maciaszczykm 4e75bcf
add checkboxes
maciaszczykm 4dd1949
update awaiting review panel
maciaszczykm 420c56d
Merge origin/master into prod-5064 branch.
maciaszczykm 9d4a892
add k8s cards
maciaszczykm e216219
add k8s actions to actions panel
maciaszczykm 4d16056
add delete variant
maciaszczykm be61aac
move diff viewer to design system
maciaszczykm ef44fc9
update memo display
maciaszczykm d45c101
protect secret bodies and make approval atomic
maciaszczykm 3b96441
regenrate schema
maciaszczykm 12e13e2
fix build
maciaszczykm 964a4d0
elixir cleanup
michaeljguarino 4f64e7e
cleanup elixir changes
michaeljguarino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
assets/design-system/src/components/icons/GoogleCloudRunIcon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import createIcon from './createIcon' | ||
|
|
||
| const icon = | ||
| 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAERElEQVR4AZxVW0xcVRRd+9x7y2OAMsC0QAtCLZq2iUCT1sTQShsf1JjAD1/GtDb+NtH0o/Jh5Mf0A43xmWjU6GdRY6IQf7S2VFpSE5uY2DagplKttjyEeTN37tnuMzPMiymoO2fdu++5e691zt7nziiUNKbBUbZ6h9n+NzCxAFMpqjUChvDQ6eje+enIx8qOTioncnFdSIyJPfBytNvkFosUCTBpK9hOmkeI8BSI90vCvnUhMSbWIR4xucU7KRB4bASVFqkjDPTiPxozDtlw+gxHfmpOYJhVLBG5F4QTUkwZ+WEb+5JAUN6JFIdwIWNZgV4s1ViMZwi0M/Puf9yowwaOPVKO6tXklMDgIFuWY3crwtHVF+Ze7gB1PoLMw1cGbK5M+1jHCDjqJcJdhtOEpQTm9oT8DPWcTPgF2bGlhvDwLgvtAUJbA+HwbgsdjQpGOBu01qmDwvOL3aFa80pB6mU5qo/BR8xEPhIesL2O8OgegvaS6NgKPNmlsLdNob6KIKcnPzznEz2hWT1uuNVBe3GbBk4SIAXJxRhvKcK4uchokrVoL4GZWyuIxBJornHxkHRq51ZCmRTdxObDcAlOHrZjTUrxpuPy0JkfsOrHXeD3BYZSCqZcS2EXC6Ekfv4zDn+li74HFHrut+CXPpXYTbdm75j0j44LoWjItcRYCGtEE4TWgI25oId7Ag4G9lehfYuDfTssPN2zScpmobZCvp7CfBJ7VoEQKpwvfiIQATJg7i0NDg7srsRBQbPfgdYe3EQcXiIG1kkUGCGumPlNmZR2yrXEaKgmOaKM2TkXzX47BRMWXdGYvBbFR2eX8cX3YSwGRcTNiciCNLN6W1kWfyoJE4I1wxzHlnqC52ncXpbySFk2+xRm512MXgzhw7NBXLgWx3JUwxSIPVd2Ek3thBnfeco7o74Zql4EaEQQRpGZ5rXIMb25kISsCI21Fqam4/jg62V8PhXGL7ddJJKGOpdoypR0o1HP069cGKqalx4Ql7mVk/Jr/kkuLO1ZxHI0Y/jqhwhkE7g8E8f7Qj55PY6/I7LqQu50klzZ8z5zoskJELGSZzwIhFnjHfH/EGTHnaDGxNUV3Ljj4ob04NxPMfxaYtXZBOMQbslu3+qp8KcOT0pgeJg0kpHrHvhdWZQMEwkkPEIwsQkgB9EVRih291UjY6z5PcspuzpsOGUuJSB3nHspEFG2MyrqV8xzGgRl2VBOOUjZ2Nj4isf6jOFajc0KmHrF/5qb1Yw35GXesaWMSMUGIpTUsF5H3P7NcCFjOQGZuPTa9jgs9zxAX6LASEQc2cndReR7GvM893yKAzkrEID8Cfeu1M6y9l7QGq+CMcbA+CrIcsaVXTYOqHEhTAM8BqaRBLunpsrbZg0H8qxIADDN+fbF6unAj75T9ff5Bho6fP35COyq62/s3Nbf1NWaRmfrQOPMpaHLp3fMINNY5Nk/AAAA///Eup1SAAAABklEQVQDAKtD2E0fWLTJAAAAAElFTkSuQmCC' | ||
|
|
||
| export default createIcon(({ size, color, fullColor }) => ( | ||
| <svg | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| {fullColor ? ( | ||
| <image | ||
| href={icon} | ||
| width="24" | ||
| height="24" | ||
| /> | ||
| ) : ( | ||
| <> | ||
| <mask | ||
| id="google-cloud-run-icon-mask" | ||
| maskUnits="userSpaceOnUse" | ||
| style={{ maskType: 'alpha' }} | ||
| > | ||
| <image | ||
| href={icon} | ||
| width="24" | ||
| height="24" | ||
| /> | ||
| </mask> | ||
| <rect | ||
| width="24" | ||
| height="24" | ||
| fill={color} | ||
| mask="url(#google-cloud-run-icon-mask)" | ||
| /> | ||
| </> | ||
| )} | ||
| </svg> | ||
| )) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import createIcon from './createIcon' | ||
|
|
||
| const icon = | ||
| 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABcAAAAYCAYAAAARfGZ1AAAD5UlEQVR4AYxVXWhcVRD+5tx79yfZ/DSbRJv0oSi1SvWhUAoRlEqeJKKVmqIgIhRa9MmiIKKWa4sW9EUQrQiCPvkHPolCRXwUIS+C0FJ8qKBttbtpm2x2s/fnjN/Zzf6km11zdubOOTNzvpk7d85Zg9vG6mt3TkWnijeiN4sJZdrhydX49fGH9TiC27b0XfaANz3FQMjoZmTV89/BzEyggGAbw2zDp+XicbI/RnQvvsa29vU4FcaTdab1s0DPE+wnQJeh/KEBmBOLR/DLrgxt/0s94KiV1vzZ0qJ/o/xEYOQwwT8nSkJ2ZBjneUyv5lQhTjGIe8AlhJUTiOUD1BFeX7M2/ZABVtogKnuiqlnACfhtXZ9JD3i3nxA1Su1N5nipS58x4j2O8clcl27L6UBwt2MkHlqnXGLVlRIMxJh4sBboKBVujn5jILjbXAlkiPU9gC4Y1n0q8PACwsE9PxD8ajiTz3jRiyKyH+iCV3G9/hzi4hQGjL7gGsLssPU5Y8xJ7s+SOyQukExExj7k/DqGzbMtwRsbKnfkPZU3WJICtwjZkbrHBjOgOXIZyNCnZd8wNcWW4DT5ST5+mXKOOXqUjiwfrmuc5BSeiMzvTsZmcbRxwJxuE/eAa4hMrToxrZCXCNy6pHiI9EKQ6rwC/xLBBRB26nBqglexD60EaOrQJnBlnSv1wliQM19CZIxuZqMFK8bSulIuEfBXMoPRCvEtdA7ZsWFd7A2wCRysc+BnF9lqB7m1ZXN3zaeeP/qdO7Ue9Auo1Gl3RB/ZG9eDu7Fvd+stnb7BNDYkmJdfL9R2eoK3AWk6KlIVlH1j35fwsjtM8IbN98z8LwCWDCh8tfgKuVtZBVgqtEcbHBgveGlwViGjbavoLVF9Cli+0tYtlapE+IzrZvZckHbGa+YehPA0hHElcrIBvsR/lyiWRyGyADS+vFImfJz72yv/JuFGllTKN0gjCK9iVLh0xNsZOVE5hGi6mNiJ+fi+4nEkxb2NKA/MTOwR432sAHvX+SPl+17KGH2X923U0HQ9hmreRdr/pCohAwJRg1OJl15QmG+5fC8xeszgwOSQWHmFDnkArjtSprKSpHqM5aiGYSdr2pt08J91EXOSi8Z3oHRUUJEdnBR4qHgfmUMmraQshTwDhbufLY1Vq/gkHywvSYhmZlR2kxxF6kv8O7Mnd1uIonxrQY1aa1S8Z6m6qoIrClxj1j9mvJG3+gFzU5PKNx2A6/mYQVzpqjSsCPCDGPtkPfEXTHC69FjmTOmu7OnSLvJscKZ8RMJm29G5PxUR21g+YmJ/0OkcO+PpwNj7/Yulw0G4fH7k7LXr/wEAAP//oYg0lgAAAAZJREFUAwB8uWLGeMjfdQAAAABJRU5ErkJggg==' | ||
|
|
||
| export default createIcon(({ size, color, fullColor }) => ( | ||
| <svg | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 23 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| {fullColor ? ( | ||
| <image | ||
| href={icon} | ||
| width="23" | ||
| height="24" | ||
| /> | ||
| ) : ( | ||
| <> | ||
| <mask | ||
| id="lambda-icon-mask" | ||
| maskUnits="userSpaceOnUse" | ||
| style={{ maskType: 'alpha' }} | ||
| > | ||
| <image | ||
| href={icon} | ||
| width="23" | ||
| height="24" | ||
| /> | ||
| </mask> | ||
| <rect | ||
| width="23" | ||
| height="24" | ||
| fill={color} | ||
| mask="url(#lambda-icon-mask)" | ||
| /> | ||
| </> | ||
| )} | ||
| </svg> | ||
| )) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
assets/design-system/src/components/icons/MicrosoftActionsIcon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import createIcon from './createIcon' | ||
|
|
||
| const icon = | ||
| 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAVCAYAAABc6S4mAAACP0lEQVR4AaSVsW4TQRCGZ9e5hiYpAuItkKCJkyI2JQWPAUKCltZ2QUUJEgqPQY1wIoGDQATBYyCEoEgi4rvd7Le6ueyd75KTYvnP7s78/z+j2fPFSs/P8setaf7z5jzi6+ZH92H9myI/2HzYZdO7gBGZiDcjYE6KHe/kLpDwWdv9/S4srd9eBZbfb48q9dKJgDLgBtms3LYuvQqYQTFRtTkudCt+YF5f1j3EzgLDt4v59t6naeye0cAGZffGytHa+O+zrTeHI7ik2rBSIAr2Ft54f7B4vDOtiU4uutfRfH4y3Ic7DBq0NX441ApAMNbPjfiZmtfHkweJrIwGLhq0eERS+acqQAICRATka+MpR0PcFP5p8X7dK/L5xis0aPHACx6IBZg1CQgQSYC0e1l6kcxKDYGkdxG2ghYPvPAkZtl4MRMSEAhWSC/3xkD8RlZBOXoXesYDLzzxtt6YXZIkWFN4kVmKKse4Aroe09TLHj7aHouRfR61dHaYZXd+TVMQA/wW0tEQS4EXnhSyJGKRsGF2zSIhHL/xwtmFR9UU7sje/3ePYxOY89iqZywAiQCz6yqiF26Oc2nOHT2N8VvAnM6JgaoABxKdRbjw0H3b3DGnMbR44KWoFSAIASIChMTieMKl2tM8vh6IKeDARYNW47quFCABEQF7EMdz6r50zd07M0YDt4nWApAQ8J6J3Z/5kTj7gngTcEAzrufOAkpg9bl7edVrGV4bri7w/+xBtvXneZu4T+zSAvyvvY45DZwDAAD//45G9PoAAAAGSURBVAMARbFYWb7haUoAAAAASUVORK5CYII=' | ||
|
|
||
| export default createIcon(({ size, color, fullColor }) => ( | ||
| <svg | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 24 21" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| {fullColor ? ( | ||
| <image | ||
| href={icon} | ||
| width="24" | ||
| height="21" | ||
| /> | ||
| ) : ( | ||
| <> | ||
| <mask | ||
| id="microsoft-actions-icon-mask" | ||
| maskUnits="userSpaceOnUse" | ||
| style={{ maskType: 'alpha' }} | ||
| > | ||
| <image | ||
| href={icon} | ||
| width="24" | ||
| height="21" | ||
| /> | ||
| </mask> | ||
| <rect | ||
| width="24" | ||
| height="21" | ||
| fill={color} | ||
| mask="url(#microsoft-actions-icon-mask)" | ||
| /> | ||
| </> | ||
| )} | ||
| </svg> | ||
| )) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { DiffMethod, DiffViewer } from '..' | ||
|
|
||
| const OLD_VALUE = `apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: demo | ||
| namespace: default | ||
| data: | ||
| feature: enabled | ||
| ` | ||
|
|
||
| const NEW_VALUE = `apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: demo | ||
| namespace: default | ||
| data: | ||
| feature: disabled | ||
| extra: true | ||
| ` | ||
|
|
||
| export default { | ||
| title: 'DiffViewer', | ||
| component: DiffViewer, | ||
| argTypes: { | ||
| splitView: { | ||
| control: 'boolean', | ||
| }, | ||
| asCard: { | ||
| control: 'boolean', | ||
| }, | ||
| hideLineNumbers: { | ||
| control: 'boolean', | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| function Template(args: any) { | ||
| return ( | ||
| <div style={{ maxWidth: 720 }}> | ||
| <DiffViewer {...args} /> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| export const Default = Template.bind({}) | ||
| Default.args = { | ||
| oldValue: OLD_VALUE, | ||
| newValue: NEW_VALUE, | ||
| splitView: false, | ||
| compareMethod: DiffMethod.LINES, | ||
| asCard: true, | ||
| } | ||
|
|
||
| export const DeletedFile = Template.bind({}) | ||
| DeletedFile.args = { | ||
| oldValue: OLD_VALUE, | ||
| newValue: '', | ||
| splitView: false, | ||
| compareMethod: DiffMethod.LINES, | ||
| asCard: true, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
embedding a png seems like the wrong approach here. You can either generate an svg from it with a tool or ask the ai to do that for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a ton of these, I usually just prompt the ai to search for brand icons online, and generate the appropriate svg from them. It can normally figure it out, and often find one that's already availale online with web search.