Bugfix: Fix dcc.Markdown issues with <dccLink /> - #3960
Merged
Conversation
T4rk1n
reviewed
Aug 28, 2026
Comment on lines
+66
to
+75
| const renderMarkdown = (text: string) => ( | ||
| <MarkdownContent | ||
| dedent={dedent} | ||
| dangerously_allow_html={dangerously_allow_html} | ||
| mathjax={mathjax} | ||
| link_target={link_target} | ||
| > | ||
| {text} | ||
| </MarkdownContent> | ||
| ); |
Contributor
There was a problem hiding this comment.
Think we can put this in a useCallback
|
|
||
| // Reuse a highlight.js instance already on `window` (e.g. supplied by the host | ||
| // page), otherwise lazily load the bundled third-party build. | ||
| export default (): Promise<HLJSApi> => |
| } | ||
| } | ||
|
|
||
| export default (mathjax?: boolean): Promise<MathJaxObject | undefined> => |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dcc.Markdownused dependencies that were fundamentally incompatible with our<dccLink />implementation + React 19 deps.This PR rewrites the Markdown component to use markdown internals that are compatible.
Along the way, it's converted to Typescript.
dcc.Linkis also converted to Typescript (no functional change) so as not to introduce TS compile errors.Testing notes:
Markdown.react.jsimplementation for parityFixes #3951
Contributor Checklist
optionals
CHANGELOG.md