Conversation
T4rk1n
commented
Jul 30, 2025
T4rk1n
commented
Contributor
- Update build dependencies
- Update dash-renderer cookie version to latest
- Replace request in dash-html-components build scripts with native fetch.
- Update styled-jsx in core components
gvwilson
approved these changes
Jul 30, 2025
gvwilson
left a comment
gvwilson
left a comment
Contributor
There was a problem hiding this comment.
It looks OK but I have a question about the code changes that are landing at the same time.
| // fs.readFile('./data/attributes.html', 'utf-8', (error, html) => { | ||
| request(htmlURL, (error, response, html) => { | ||
| if (error) { | ||
| fetch(htmlURL) |
Contributor
There was a problem hiding this comment.
why is this in with dependencies upgrade? (not arguing against it, just don't understand)
Contributor
Author
There was a problem hiding this comment.
The request dependency keeps on having security vulnerability and there was no resolving from updating, fetch has been natively available since node v18 so I opted to replace it instead.
|
|
||
| request(refUrl, (error, response, html) => { | ||
| if (error) { | ||
| fetch(refUrl) |
Contributor
There was a problem hiding this comment.
same question as above - how does this tie to dep upgrade?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.