feat: Expose NoUpdate type - #3369
Merged
Merged
Conversation
ytausch
marked this pull request as ready for review
July 15, 2025 17:06
ytausch
requested review from
T4rk1n,
emilykl,
gvwilson and
ndrezn
as code owners
July 15, 2025 17:06
T4rk1n
reviewed
Jul 16, 2025
T4rk1n
requested changes
Jul 16, 2025
T4rk1n
left a comment
Contributor
There was a problem hiding this comment.
Maybe we should add obj is NoUpdate or ... in the conditions of NoUpdate.is_no_update if this is exposed so it could be used as is.
Contributor
Author
|
Isn't this already the case? If you mean an isinstance check. Lines 1 to 9 in 1f4337a |
Contributor
Author
|
Ah, you referred back to the original issue. I added the condition. |
T4rk1n
reviewed
Jul 16, 2025
T4rk1n
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a formatting issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2800.
Contributor Checklist
dash.NoUpdateoptionals
CHANGELOG.md