[codex] add default language sync for control panel#2021
Conversation
|
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@davisagli No clue why all these failures... |
|
@sneridagh The desired feature here isn't specific to the REST API. It should happen when the default language is changed via any UI. So instead of implementing it in a deserializer, I think we should add this to what is taken care of by this event handler in plone.app.multilingual: https://github.com/plone/plone.app.multilingual/blob/master/src/plone/app/multilingual/subscriber.py#L184 |
What changed
ILanguageSchema.default_language.@controlpanels/languagechangesdefault_languageon non-multilingual sites.test_services_controlpanel_language.pyand added a towncrier fragment.Why
Validation
📚 Documentation preview 📚: https://plonerestapi--2021.org.readthedocs.build/