fix: guard Plex finish kill when no PID is found#169
Open
OmarB97 wants to merge 2 commits into
Open
Conversation
Author
Thanks, pushed c506e49 to address this. I quoted the PID handling, but used a small I applied the same path for both the SIGTERM and SIGKILL calls and checked it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard the initial
kill -15 $pidscall inroot/etc/services.d/plex/finishso it only runs when a Plex Media Server PID was found.Why
If Plex has already exited by the time the finish script runs,
pidsis empty and the shell executeskill -15without a PID. That prints thekill: usage...message during container shutdown. The later SIGKILL block already guards against an empty PID list, so this makes the TERM path match the existing stuck-process path.Validation
bash -n root/etc/services.d/plex/finishplexinc/pms-docker:latest, where the shutdown logs showedkill: usage...; applying the guard removed that message while Plex restarted healthy.