Skip to content

fix: skip backports the release branch already has - #2432

Merged
kpal81xd merged 1 commit into
mainfrom
fix/release-skip-applied-backports
Oct 22, 2026
Merged

kpal81xd merged 1 commit into
mainfrom
fix/release-skip-applied-backports

Conversation

@kpal81xd

Copy link
Copy Markdown
Contributor

What's Changed

Patch releases stopped with "Backport of #2425 conflicts on release-2.35" even though #2425 was already on the release branch. It had been backported earlier with a slightly different lockfile diff, so git cherry didn't match it, and cherry-picking it again produced an empty commit. git cherry-pick exits non-zero on an empty result, and the release script treated that as a conflict.

  • Backports now cherry-pick with --empty=drop. A fix the branch already has is dropped and logged as Skipping #N: already on release-X.Y.
  • Real conflicts still stop the release without pushing.
  • New test: a fix already on the release branch under a different patch is skipped, and the patch release goes ahead.

Manual smoke test

  1. Run the Release workflow with type patch. Expected: the log shows Skipping #2425: already on release-2.35, the remaining labelled fixes are backported, and the next patch tag is pushed.

Checks

A fix backported by hand under a different patch cherry-picks as an empty commit, which failed the release as a conflict. Empty picks are now dropped and logged as already on the branch.
@kpal81xd kpal81xd added bug Something isn't working release: next patch Ticket marked for next patch release labels Oct 22, 2026
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
editor Ready Ready Preview Oct 22, 2026 5:49pm UTC

Request Review

@kpal81xd
kpal81xd merged commit baa05fe into main Oct 22, 2026
12 checks passed
@kpal81xd
kpal81xd deleted the fix/release-skip-applied-backports branch October 22, 2026 18:08
playcanvas-bot Bot pushed a commit that referenced this pull request Oct 22, 2026
A fix backported by hand under a different patch cherry-picks as an empty commit, which failed the release as a conflict. Empty picks are now dropped and logged as already on the branch.

(cherry picked from commit baa05fe)
@kpal81xd
kpal81xd restored the fix/release-skip-applied-backports branch October 22, 2026 18:21
@kpal81xd
kpal81xd deleted the fix/release-skip-applied-backports branch October 22, 2026 18:23

This branch was successfully deployed

1 active deployment
Preview — 9f256473 Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release: next patch Ticket marked for next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant