feat: adopt slim facade (block/src + from-pack-v2 BlockPointer) #126
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@platforma-open/milaboratories.samples-and-data": minor | ||
| --- | ||
|
|
||
| Adopt the slim from-pack-v2 facade. The published package now carries only the | ||
| block's type surface plus a dependency-free `from-pack-v2` BlockPointer; the | ||
| model/ui/workflow packages are kept as private build-time siblings. Migrated onto | ||
| the published facade SDK toolchain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // This file is managed by `block-tools structure`. Do not edit by hand. | ||
| // Narrow MCP / AI surface. | ||
|
|
||
| export type { BlockContract, BlockOutputs, BlockData } from "./index"; | ||
| export * from "./agents-extra"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Author-owned. `block-tools structure` does not modify this file. | ||
| // MCP / AI extension surface. Add types and functions the agent | ||
| // surface should expose. | ||
| // | ||
| // In the future this file will host JS functions the MCP runtime | ||
| // can execute. The `.d.ts` declarations stay visible to the agent; | ||
| // the JS bodies execute in the MCP code-execution context (the | ||
| // agent sees the types but not the implementation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // Author-owned. `block-tools structure` does not modify this file. | ||
| // Add block-specific helper types or values the consumer surface | ||
| // should expose. Anything you `export` here flows out via the | ||
| // main entry (./index re-exports this file). | ||
| // | ||
| // Do NOT redefine: BlockContract, BlockOutputs, BlockData, BlockHref, | ||
| // BlockPointer, platforma, or the block-named <PascalName>Block* | ||
| // aliases — those names come from ./index and `export *` from this | ||
| // file would shadow them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,55 @@ | ||||||||
| // This file is managed by `block-tools structure`. Do not edit by hand. | ||||||||
| // Author content lives in ./block-extra.ts. | ||||||||
|
|
||||||||
| import { platforma } from "@platforma-open/milaboratories.samples-and-data.model"; | ||||||||
| import { | ||||||||
| InferOutputsType, | ||||||||
| InferDataType, | ||||||||
| InferHrefType, | ||||||||
| } from "@platforma-sdk/model"; | ||||||||
|
|
||||||||
| export { platforma }; | ||||||||
|
|
||||||||
| export type BlockContract = { | ||||||||
| outputs: InferOutputsType<typeof platforma>; | ||||||||
| data: InferDataType<typeof platforma>; | ||||||||
| href: InferHrefType<typeof platforma>; | ||||||||
| }; | ||||||||
|
|
||||||||
| export type BlockOutputs = BlockContract["outputs"]; | ||||||||
| export type BlockData = BlockContract["data"]; | ||||||||
|
|
||||||||
| // import.meta.url is a file: URL (always forward-slash, even on Windows: | ||||||||
| // file:///C:/…). We expose URLs, NOT paths — the facade stays dependency-free | ||||||||
| // and loadable in minimal engines (e.g. QuickJS), and each consumer converts | ||||||||
| // at its own edge with the right tool (fileURLToPath in Node), where Windows | ||||||||
| // drive letters / %-encoding / UNC are handled correctly. The bundled entry | ||||||||
| // sits one dir under the package root (dist/index.js, or src/index.ts in dev), | ||||||||
| // so the root is two URL segments up. The structurer owns this layout — | ||||||||
| // consumers read these URLs, they never reconstruct <root>/block-pack. | ||||||||
| // | ||||||||
| // TypeScript ships `ImportMeta.url` only in the `dom`/`webworker` libs; the | ||||||||
| // facade tsconfig is lib-minimal (no `dom`, no `@types/node`) by design. We | ||||||||
| // type the one ESM-standard member we use with a local cast rather than a | ||||||||
| // `declare global` — a global augmentation would leak into the published | ||||||||
| // `dist/index.d.ts` and clash with `@types/node`'s `ImportMeta` in full-Node | ||||||||
| // consumers (test packages, the Middle Layer). | ||||||||
| const selfUrl = (import.meta as ImportMeta & { url: string }).url; | ||||||||
|
There was a problem hiding this comment. Using a type assertion like
Suggested change
|
||||||||
| const dirUrl = selfUrl.slice(0, selfUrl.lastIndexOf("/")); | ||||||||
| const rootUrl = dirUrl.slice(0, dirUrl.lastIndexOf("/")); | ||||||||
|
|
||||||||
| export const BlockPointer = { | ||||||||
| type: "from-pack-v2" as const, | ||||||||
| packUrl: rootUrl + "/block-pack", | ||||||||
| rootUrl, | ||||||||
| } as const; | ||||||||
|
|
||||||||
| // Block-named aliases for readable cross-block imports in tests and | ||||||||
| // consumer code. Same types / same runtime value as the universal | ||||||||
| // names above; the aliases avoid `as`-renames at the import site. | ||||||||
| export type SamplesAndDataBlockContract = BlockContract; | ||||||||
| export type SamplesAndDataBlockOutputs = BlockOutputs; | ||||||||
| export type SamplesAndDataBlockData = BlockData; | ||||||||
| export const SamplesAndDataBlockPointer = BlockPointer; | ||||||||
|
|
||||||||
| export * from "./block-extra"; | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "extends": "@milaboratories/ts-configs/block/facade", | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The secret lookup was changed from
AWS_CI_TURBOREPO_US_S3_BUCKETtoAWS_CI_TURBOREPO_S3_BUCKET. If the GitHub org/repo only has the old secret (AWS_CI_TURBOREPO_US_S3_BUCKET), the new reference will resolve to an empty string — GitHub never errors on a missing secret — and Turborepo remote caching will silently be disabled. Could you confirm the org secret has already been renamed (or a new one added) before this is undrafted? Has the GitHub secretAWS_CI_TURBOREPO_S3_BUCKETbeen created/renamed at the org or repo level, or is this intentionally deferring to the finalization step?Prompt To Fix With AI