Stricter form submissions

[jzgom067]

This PR introduces stricter form submissions to the many "forms" we have on the site.

Submission Restriction

On each "form" (listed below), the frontend will check that all the fields are filled and that there are no errors before allowing submission.

The submit button will be disabled and have a relevant tooltip on desktop. The behavior remains the same on mobile, where it shows toasts on submission if anything is wrong.

Affected forms:

• All auth pages (forgot password, login, register, reset password)
• Event editor (new and edit)
• Painting page
• Authed password change/reset flow
• Account deletion

Submit Disabling on Form Dialog

New props were added to allow adding tooltips and a disabled state to the submit button on form dialogs.

[coderabbitai]

Walkthrough

The change adds memoized form validation across authentication, account, painting, and event editor forms. Desktop submit buttons are disabled when forms are invalid and show validation tooltips. Mobile submit buttons remain enabled. FormDialog now supports submit-button disabled and tooltip props. Painting errors now use centralized error handling. Shared validation messages were added.

Mergeability Score: 🟡 Moderate · up to dd1b1

The stricter submission behavior currently has cases that can permanently block retries, enable submission despite mismatched passwords, keep corrected password forms disabled, or allow a painting name with an existing availability error to proceed on mobile. These are concrete correctness and availability issues, so the PR is not merge-ready until they are addressed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 8

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/app/(event)/[event-code]/painting/page-client.tsx (1)

125-135: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use the trimmed-name rule while editing.

validateAvailabilityData treats whitespace-only input as missing, but handleNameChange checks only value === "". For " ", the handler clears errors.displayName and starts checkNameAvailability. Use !value.trim() so field validation and submit validation use the same rule.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2507e117-2dc6-4ae7-929a-0236766e56df

📥 Commits

Reviewing files that changed from the base of the PR and between 53ec3d7 and dd1b181.

📒 Files selected for processing (12)

• frontend/src/app/(auth)/forgot-password/page.tsx
• frontend/src/app/(auth)/login/page.tsx
• frontend/src/app/(auth)/register/page.tsx
• frontend/src/app/(auth)/reset-password/page.tsx
• frontend/src/app/(event)/[event-code]/painting/page-client.tsx
• frontend/src/features/account/setting-dialogs/change-password/main-dialog.tsx
• frontend/src/features/account/setting-dialogs/change-password/use-change-password.ts
• frontend/src/features/account/setting-dialogs/delete-account.tsx
• frontend/src/features/event/editor/editor.tsx
• frontend/src/features/system-feedback/dialog/components/form.tsx
• frontend/src/features/system-feedback/dialog/props.ts
• frontend/src/lib/messages.ts