Invoke onLoad for standard Link sessions - #943
Merged
Merged
Conversation
|
Coverage after merging codex/standard-link-onload into master will be
Coverage Report
|
|||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.onLoad?.()after native Standard Link session creation resolves.Motivation
Native iOS and Android resolve
createPlaidLinkSessionwhen Link finishes loading, but the JS Standard Link wrapper did not invoke the documentedonLoadcallback. Headless already had this behavior; this brings Standard Link into parity with the documented API and native readiness signal.Testing
npm test -- --runInBand src/__tests__/createPlaidLinkSession.test.ts src/__tests__/createPlaidHeadlessSession.test.ts --watchman=falsenpm run lint