Skip to content

chore: apply CI best practices #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maw629 merged 4 commits into from
Jul 27, 2026
Merged

chore: apply CI best practices #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddfffcc
chore: pin actions/checkout using commit hash
maw629 Jul 27, 2026
218db55
chore: pin actions/setup-node using commit hash
maw629 Jul 27, 2026
81d5c00
chore: pin actions/cache using commit hash
maw629 Jul 27, 2026
395029a
chore: add '--ignore-scripts' flag for 'npm ci' command
maw629 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/asset-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
- uses: chrysanthos/simple-asset-size-reporter@1.0.2
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
environment: npm-publish # binds this job to the approval-gated env
steps:
- name: Checkout the tagged commit
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ github.event.release.tag_name }}

- name: Set up Node
uses: actions/setup-node@v7
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22.x
registry-url: 'https://registry.npmjs.org'
Expand All @@ -29,7 +29,7 @@ jobs:
run: npm install -g npm@11.10.0

- name: Install dependencies (honor lockfile)
run: npm ci
run: npm ci --ignore-scripts

- name: Build dist artifacts
run: npm run build
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ jobs:
git config --global core.autocrlf false
git config --global core.symlinks true
if: runner.os == 'Windows'
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v7
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: ${{ matrix.node-version }}
- name: Pin npm version
run: npm install -g npm@11.10.0
- name: Cache node modules
uses: actions/cache@v6
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.npm
key: v2-${{ runner.os }}-node-${{ matrix.node-version }}-npm-${{ hashFiles('**/package-lock.json') }}
Expand All @@ -49,20 +49,20 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
- name: Pin npm version
run: npm install -g npm@11.10.0
- name: Cache node modules
uses: actions/cache@v6
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.npm
key: v2-npm-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
v2-npm-
- run: npm ci
- run: npm ci --ignore-scripts
- run: npm run benchmark
env:
CI: true
Expand All @@ -73,20 +73,20 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
- name: Pin npm version
run: npm install -g npm@11.10.0
- name: Cache node modules
uses: actions/cache@v6
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.npm
key: v2-npm-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
v2-npm-
- run: npm ci
- run: npm ci --ignore-scripts
- run: npx tsc -p tsconfig.check.json
env:
CI: true