Skip to content

Improve safety checks in resize.ts & fit.ts - #255

Merged
CyberDex merged 1 commit into
pixijs:mainfrom
jeth88:utils-safety-checks
Aug 26, 2026
Merged

Improve safety checks in resize.ts & fit.ts#255
CyberDex merged 1 commit into
pixijs:mainfrom
jeth88:utils-safety-checks

Conversation

@jeth88

@jeth88 jeth88 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor
  • Added guard condition for undefined view in resize.ts → centerView
  • Throw error when child is undefined in fit.ts → fitToView
  • Deferred assignment of child.scaleX/scaleY until all parameters are validated (related to the above change)

@jeth88
jeth88 marked this pull request as ready for review April 3, 2026 09:21
@CyberDex
CyberDex merged commit 0044642 into pixijs:main Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberDex CyberDex CyberDex approved these changes
@Zyie Zyie Awaiting requested review from Zyie Zyie is a code owner
@GoodBoyDigital GoodBoyDigital Awaiting requested review from GoodBoyDigital GoodBoyDigital is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeth88 @CyberDex