Use Pixeltable query routes directly - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pixelbot carried two implementations of the same memory and persona reads: declarative
@pxt.queryfunctions plus a plain-Pythonqueries.pylayer used by legacy FastAPI endpoints. The duplicate layer could drift, and the frontend-facing query routes required auser_idparameter that the frontend did not send.This change makes the app entry a clearer Pixeltable example:
FastAPIRouterroutes inpixelbot/app.py/api/memoryand/api/personas, with semantic search at/api/memory/searchqueries.py, the versioned v2 reads, the duplicate manual-write alias, and the backend-only download endpointValidation:
pxt schema checkpassesmainremains fully in agreement: 19/19 models, zero schema operationspxt service updateserved health, canonical memory/persona reads, and the notification log; valid responses returned 200, removed v2 paths returned 404, and notification limits above 100 returned 422No provider or hosted calls were made.