[Aikido] Fix 16 security issues in fast-xml-parser, fast-uri, yaml and 4 more#39
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
Conversation
Package lock diff2.4.1 -> 2.6.1 node_modules/@aws-cdk/asset-awscli-v1 2.2.242 -> 2.2.282 node_modules/@aws-cdk/asset-node-proxy-agent-v6 2.1.0 -> 2.1.2 node_modules/@aws-cdk/cloud-assembly-schema 45.2.0 -> 54.2.0 node_modules/@aws-cdk/cloud-assembly-schema/node_modules/jsonschema 1.4.1 -> 1.5.0 node_modules/@aws-cdk/cloud-assembly-schema/node_modules/semver 7.7.2 -> 7.8.1 node_modules/@aws-sdk/client-cognito-identity 3.840.0 -> 3.1063.0 node_modules/@aws-sdk/client-secrets-manager 3.840.0 -> 3.1063.0 node_modules/@aws-sdk/client-sso removed node_modules/@aws-sdk/core 3.840.0 -> 3.974.18 node_modules/@aws-sdk/credential-provider-cognito-identity 3.840.0 -> 3.972.42 node_modules/@aws-sdk/credential-provider-env 3.840.0 -> 3.972.44 node_modules/@aws-sdk/credential-provider-http 3.840.0 -> 3.972.46 node_modules/@aws-sdk/credential-provider-ini 3.840.0 -> 3.972.50 node_modules/@aws-sdk/credential-provider-node 3.840.0 -> 3.972.52 node_modules/@aws-sdk/credential-provider-process 3.840.0 -> 3.972.44 node_modules/@aws-sdk/credential-provider-sso 3.840.0 -> 3.972.49 node_modules/@aws-sdk/credential-provider-web-identity 3.840.0 -> 3.972.49 node_modules/@aws-sdk/credential-providers 3.840.0 -> 3.1063.0 node_modules/@aws-sdk/middleware-host-header removed node_modules/@aws-sdk/middleware-logger removed node_modules/@aws-sdk/middleware-recursion-detection removed node_modules/@aws-sdk/middleware-user-agent removed node_modules/@aws-sdk/nested-clients 3.840.0 -> 3.997.17 node_modules/@aws-sdk/region-config-resolver removed node_modules/@aws-sdk/token-providers 3.840.0 -> 3.1063.0 node_modules/@aws-sdk/types 3.840.0 -> 3.973.11 node_modules/@aws-sdk/util-endpoints removed node_modules/@aws-sdk/util-user-agent-browser removed node_modules/@aws-sdk/util-user-agent-node removed node_modules/@aws-sdk/xml-builder 3.821.0 -> 3.972.28 node_modules/@smithy/abort-controller removed node_modules/@smithy/config-resolver removed node_modules/@smithy/core 3.6.0 -> 3.24.6 node_modules/@smithy/credential-provider-imds 4.0.6 -> 4.3.8 node_modules/@smithy/fetch-http-handler 5.0.4 -> 5.4.6 node_modules/@smithy/hash-node removed node_modules/@smithy/invalid-dependency removed node_modules/@smithy/is-array-buffer removed node_modules/@smithy/middleware-content-length removed node_modules/@smithy/middleware-endpoint removed node_modules/@smithy/middleware-retry removed node_modules/@smithy/middleware-serde removed node_modules/@smithy/middleware-stack removed node_modules/@smithy/node-config-provider removed node_modules/@smithy/node-http-handler 4.0.6 -> 4.7.7 node_modules/@smithy/property-provider removed node_modules/@smithy/protocol-http removed node_modules/@smithy/querystring-builder removed node_modules/@smithy/querystring-parser removed node_modules/@smithy/service-error-classification removed node_modules/@smithy/shared-ini-file-loader removed node_modules/@smithy/signature-v4 5.1.2 -> 5.4.6 node_modules/@smithy/smithy-client removed node_modules/@smithy/types 4.3.1 -> 4.14.3 node_modules/@smithy/url-parser removed node_modules/@smithy/util-base64 removed node_modules/@smithy/util-body-length-browser removed node_modules/@smithy/util-body-length-node removed node_modules/@smithy/util-buffer-from removed node_modules/@smithy/util-config-provider removed node_modules/@smithy/util-defaults-mode-browser removed node_modules/@smithy/util-defaults-mode-node removed node_modules/@smithy/util-endpoints removed node_modules/@smithy/util-hex-encoding removed node_modules/@smithy/util-middleware removed node_modules/@smithy/util-retry removed node_modules/@smithy/util-stream removed node_modules/@smithy/util-uri-escape removed node_modules/@smithy/util-utf8 removed node_modules/@types/uuid removed node_modules/ajv 6.12.6 -> 6.15.0 node_modules/aws-cdk-lib 2.204.0 -> 2.258.0 node_modules/aws-cdk-lib/node_modules/ajv 8.17.1 -> 8.20.0 node_modules/aws-cdk-lib/node_modules/balanced-match 1.0.2 -> 4.0.4 node_modules/aws-cdk-lib/node_modules/brace-expansion 1.1.12 -> 5.0.6 node_modules/aws-cdk-lib/node_modules/concat-map removed node_modules/aws-cdk-lib/node_modules/fast-uri 3.0.6 -> 3.1.2 node_modules/aws-cdk-lib/node_modules/fs-extra 11.3.0 -> 11.3.5 node_modules/aws-cdk-lib/node_modules/jsonfile 6.1.0 -> 6.2.1 node_modules/aws-cdk-lib/node_modules/minimatch 3.1.2 -> 10.2.5 node_modules/aws-cdk-lib/node_modules/semver 7.7.2 -> 7.8.1 node_modules/aws-cdk-lib/node_modules/yaml 1.10.2 -> 1.10.3 node_modules/bowser 2.11.0 -> 2.14.1 node_modules/brace-expansion 1.1.12 -> 1.1.15 node_modules/constructs 10.4.2 -> 10.6.0 node_modules/fast-xml-parser 4.4.1 -> 5.7.3 node_modules/filelist/node_modules/brace-expansion 2.0.2 -> 2.1.1 node_modules/filelist/node_modules/minimatch 5.1.6 -> 5.1.9 node_modules/minimatch 3.1.2 -> 3.1.5 node_modules/strnum 1.1.2 -> 2.3.0 node_modules/uuid removed node_modules/@aws-crypto/crc32 added node_modules/@aws-sdk/credential-provider-login added node_modules/@aws-sdk/signature-v4-multi-region added node_modules/@aws/lambda-invoke-store added node_modules/@nodable/entities added node_modules/aws-cdk-lib/node_modules/@aws-cdk/cloud-assembly-api added node_modules/fast-xml-builder added node_modules/path-expression-matcher added node_modules/xml-naming added |
Author
|
Closed by Aikido: a new AutoFix has been created → #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical XML entity injection XSS, XML entity expansion DoS attacks, stack overflow, path normalization bypass, and other security vulnerabilities.
All breaking changes by upgrading fast-xml-parser from version 4.4.1 to 5.7.3 (CHANGELOG)
✅ 16 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
preserveOrder:truecauses stack overflow leading to denial of service when processing certain inputs. The application crashes due to improper recursion handling during XML construction.*()and+()) generate regexps with catastrophic backtracking, causing severe ReDoS denial-of-service attacks with minimal input patterns triggering multi-second hangs.🤖 Remediation details
Fix security vulnerabilities in fast-xml-parser, fast-uri, yaml, minimatch, brace-expansion, @smithy/config-resolver, and ajv
Short summary
This PR remediates security vulnerabilities in seven npm packages: fast-xml-parser, fast-uri, yaml, minimatch, brace-expansion, @smithy/config-resolver, and ajv. All are transitive dependencies resolved through the root
package.jsonandpackage-lock.json. Fixes were applied via three direct dependency version bumps inpackage.json(@aws-sdk/client-secrets-manager,@aws-sdk/credential-providers,aws-cdk-lib) and lockfile-only transitive updates for the remaining packages.fast-xml-parser
fast-xml-parserwas resolved at 4.4.1, which is vulnerable; the fix requires ≥ 4.5.5. The immediate parent@aws-sdk/coreexact-pinned version 4.4.1, so a lockfile-only update was insufficient. Bumping the direct dependencies@aws-sdk/client-secrets-managerand@aws-sdk/credential-providersfrom^3.348.0to^3.844.0inpackage.jsoncaused npm to resolve@aws-sdk/coreto ≥ 3.844.0, which in turn pullsfast-xml-parserat 5.x (resolved 5.7.3), satisfying the patched version requirement.fast-uri
fast-uriwas resolved at 3.0.6 (vulnerable; fix requires ≥ 3.1.2) as a transitive dependency ofajv8.x nested insideaws-cdk-lib. Becauseajv8.17.1 declaresfast-urias^3.0.1, the fix was semver-compatible and resolved by running a lockfile-only update (npm update fast-uri --package-lock-only), bringing it to 3.1.2 without any manifest change.yaml
yamlwas resolved at 1.10.2 (vulnerable; fix requires ≥ 1.10.3) as a transitive dependency exact-pinned byaws-cdk-lib. The firstaws-cdk-librelease that pinsyamlto 1.10.3 is 2.245.0, so the direct dependency spec inpackage.jsonwas widened from^2.78.0to^2.245.0, andnpm install --package-lock-onlyresolvedyamlto 1.10.3.minimatch
minimatchwas resolved at 3.1.2 in multiple locations (vulnerable; fix requires ≥ 3.1.4). All parent packages (eslint,@eslint/eslintrc,@humanwhocodes/config-array,glob,jake,test-exclude,eslint-plugin-node) declareminimatchas^3.1.2, making the fix semver-compatible. A lockfile-only update resolved the root instance to 3.1.5. Theaws-cdk-lib-nested instance was already resolved to 10.2.5 (≥ 10.2.3) as a side effect of theaws-cdk-libparent bump.brace-expansion
brace-expansionwas resolved at 1.1.12 (root, vulnerable; fix requires ≥ 1.1.14) and 2.0.2 (nested underfilelist, vulnerable; fix requires ≥ 2.0.3). Both parentminimatchinstances declarebrace-expansionwith caret ranges (^1.1.7and^2.0.1respectively), so both were semver-compatible and resolved via a lockfile-only update to 1.1.15 and 2.1.1 respectively.@smithy/config-resolver
@smithy/config-resolverwas resolved at 4.1.4 (vulnerable; fix requires ≥ 4.4.0) as a transitive dependency of the AWS SDK packages. Bumping@aws-sdk/client-secrets-managerand@aws-sdk/credential-providersto^3.844.0inpackage.jsonresolved the AWS SDK ecosystem to a version where@smithy/config-resolveris either absorbed or resolved at ≥ 4.4.0, eliminating the vulnerable instance entirely from the lockfile.ajv
ajvappeared in two major-version instances: 6.12.6 (dev, undereslint/@eslint/eslintrc; fix requires ≥ 6.14.0) and 8.17.1 (underaws-cdk-lib/table; fix requires ≥ 8.18.0). Both parent packages declareajvwith caret ranges (^6.12.4and^8.0.1respectively), so both were semver-compatible and resolved via a lockfile-only update to 6.15.0 and 8.20.0 respectively.Version changes
@aws-sdk/client-secrets-manager^3.348.0^3.844.0@aws-sdk/credential-providers^3.348.0^3.844.0aws-cdk-lib^2.78.0^2.245.0fast-xml-parser4.4.15.7.3fast-uri3.0.63.1.2yaml1.10.21.10.3minimatch(root)3.1.23.1.5minimatch(aws-cdk-lib nested)3.1.210.2.5minimatch(filelist nested)5.1.65.1.9brace-expansion(root)1.1.121.1.15brace-expansion(filelist nested)2.0.22.1.1brace-expansion(aws-cdk-lib nested)1.1.125.0.6ajv(root, 6.x)6.12.66.15.0ajv(aws-cdk-lib nested, 8.x)8.17.18.20.0@smithy/config-resolver4.1.4